Skip to content

[BUG]: actionlint in pre-commit doesn't pass #1146

@mdboom

Description

@mdboom

Is this a duplicate?

Type of Bug

Something else

Component

General cuda-python

Describe the bug

When actionlint was added to the pre-commit config in #1018, it looks like none of our actions were actually fixed up to comply with the linter. This is one of the gotchas of pre-commit that I've run into in the past -- new lints don't get run on existing code until you edit those files, so you have to run pre-commit run --all-files to test.

This currently is blocking making changes to any of the GHA config.

Should we remove that linter and come back to it when we've fixed all the errors? (There's a lot of them, and bash isn't something I know well...)

How to Reproduce

$ pre-commit run --all-files

...dozens of errors...

Expected behavior

pre-commit run --all-files should pass cleanly.

Operating System

No response

nvidia-smi output

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions