-
Notifications
You must be signed in to change notification settings - Fork 223
Open
Labels
P0High priority - Must do!High priority - Must do!bugSomething isn't workingSomething isn't workingcuda.coreEverything related to the cuda.core moduleEverything related to the cuda.core moduletestImprovements or additions to testsImprovements or additions to tests
Milestone
Description
Using SECURITY_ATTRIBUTES was wrong:
cuda-python/cuda_core/tests/test_memory.py
Lines 318 to 334 in b1a6baf
| def get_sa(): | |
| class SECURITY_ATTRIBUTES(ctypes.Structure): | |
| _fields_ = [ | |
| ("nLength", wintypes.DWORD), | |
| ("lpSecurityDescriptor", wintypes.LPVOID), | |
| ("bInheritHandle", wintypes.BOOL), | |
| ] | |
| sa = SECURITY_ATTRIBUTES() | |
| sa.nLength = ctypes.sizeof(sa) | |
| sa.lpSecurityDescriptor = None | |
| sa.bInheritHandle = False # TODO: why? | |
| return sa | |
| if IS_WINDOWS: | |
| return (("win32", get_sa()), ("win32_kmt", None)) |
we should use
OBJECT_ATTRIBUTES instead. See discussion starting here: #1263 (comment).Metadata
Metadata
Assignees
Labels
P0High priority - Must do!High priority - Must do!bugSomething isn't workingSomething isn't workingcuda.coreEverything related to the cuda.core moduleEverything related to the cuda.core moduletestImprovements or additions to testsImprovements or additions to tests