Skip to content

Conversation

github-actions[bot]
Copy link

Description

Backport of #1047 to 12.9.x.

* Remove bitcode_dynamic code from test_nvvm.py

* New toolshed/build_static_bitcode_input.py

* Import test_nvvm to get access to MINIMAL_NVVMIR_TXT (to avoid duplicating it).

* Rename MINIMAL_NVVMIR_TXT → MINIMAL_NVVMIR_TXT_TEMPLATE for clarity.

* Minor simplifications of helper script.

(cherry picked from commit 5383cb5)
@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Sep 30, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@rwgk
Copy link
Collaborator

rwgk commented Sep 30, 2025

@leofang Should I keep or revert the toolshed/ addition in this backport PR?

@rwgk rwgk requested a review from leofang September 30, 2025 19:12
@rwgk rwgk added the cuda.bindings Everything related to the cuda.bindings module label Sep 30, 2025
@leofang
Copy link
Member

leofang commented Sep 30, 2025

no need to touch any files unless they are relevant for testing older cuda-bindings in the CI, but since the bot did the work already, it's fine to keep

@leofang leofang added this to the cuda-python 13-next, 12-next milestone Sep 30, 2025
@leofang leofang added P1 Medium priority - Should do test Improvements or additions to tests labels Sep 30, 2025
@rwgk
Copy link
Collaborator

rwgk commented Sep 30, 2025

/ok to test

@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Sep 30, 2025

/ok to test

@rwgk, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@rwgk
Copy link
Collaborator

rwgk commented Sep 30, 2025

/ok to test 4f45ffa

@rwgk rwgk merged commit 9b579bc into 12.9.x Oct 1, 2025
50 checks passed
@rwgk rwgk deleted the backport-1047-to-12.9.x branch October 1, 2025 00:20
@cpcloud cpcloud mentioned this pull request Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda.bindings Everything related to the cuda.bindings module P1 Medium priority - Should do test Improvements or additions to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants