Add numpy version check in examples/thread_block_cluster.py #1172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
Author
leofang
reviewed
Oct 22, 2025
rparolin
requested changes
Oct 23, 2025
Collaborator
rparolin
left a comment
rparolin
left a comment
There was a problem hiding this comment.
lgtm, once Leo's suggested changes are merged.
Member
|
/ok to test ea6be6e |
leofang
approved these changes
Oct 23, 2025
Member
|
/ok to test ac999ca |
leofang
approved these changes
Oct 23, 2025
This comment has been minimized.
This comment has been minimized.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is to fix issue in #1170 .
The fix is in cuda_core/examples/thread_block_cluster.py to add a numpy version check. If numpy version is less than 2.2.5, the test will skip.
After the fix, the test could be skipped when numpy version is less than 2.2.5.
example_tests/test_basic_examples.py::TestExamples::test_example[C:\tmp\cuda-python\cuda_core\tests\example_tests\..\..\examples\thread_block_cluster.py] SKIPPED [100%]