revert: feat: add from_* style constructor classmethods to StridedMemoryView and make constructor amenable to future from_*-style constructors (#1224) #1232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oryView and make constructor amenable to future from_*-style constructors (NVIDIA#1224) This reverts commit f223c17.
Contributor
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
rwgk
approved these changes
Nov 11, 2025
Collaborator
rwgk
left a comment
rwgk
left a comment
There was a problem hiding this comment.
Thanks! I'll go ahead merging this, to get this into the ctk-next update.
|
cpcloud
added a commit
to cpcloud/cuda-python
that referenced
this pull request
Nov 17, 2025
…ridedMemoryView and make constructor amenable to future from_*-style constructors (NVIDIA#1224) (NVIDIA#1232) This reverts commit a87f937.
cpcloud
added a commit
to cpcloud/cuda-python
that referenced
this pull request
Nov 17, 2025
…ridedMemoryView and make constructor amenable to future from_*-style constructors (NVIDIA#1224) (NVIDIA#1232) This reverts commit a87f937.
cpcloud
added a commit
to cpcloud/cuda-python
that referenced
this pull request
Nov 17, 2025
…ridedMemoryView and make constructor amenable to future from_*-style constructors (NVIDIA#1224) (NVIDIA#1232) This reverts commit a87f937.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1224. Will follow up tomorrow with a redo and deprecation of the current
__init__.