Fix #1051: Make _graph.py compatible with cuda-python==12.6.* and fix tests #1236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes compatibility issues with cuda-python 12.6.* by addressing two independent problems: adding version checks for CUDA 12.8-specific enums and updating test patterns to accept both driver and binding version error messages.
- Adds version check for
CUDA_GRAPH_INSTANTIATE_CONDITIONAL_HANDLE_UNUSEDenum (available only in CUDA 12.8+) - Updates test assertions to accept error messages from either driver or binding version checks
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cuda_core/cuda/core/experimental/_graph.py | Adds binding version check before accessing CUDA 12.8-specific enum to prevent AttributeError on earlier versions |
| cuda_core/tests/test_graph.py | Updates regex patterns in test assertions to match both "Driver version" and "Binding version" error messages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This comment has been minimized.
This comment has been minimized.
leofang
approved these changes
Nov 12, 2025
|
leofang
added
bug
This was referenced Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two independent issues here:
The
driver.CUgraphInstantiateResult.CUDA_GRAPH_INSTANTIATE_CONDITIONAL_HANDLE_UNUSEDenum was added in CUDA 12.8, so we can't handle it as a result type on earlier versionsThere are a number of features not supported on 12.6, and they are getting properly gated, if the driver supports the feature and the bindings don't, the exception raised will say
Bindings version (12, 6) does not support Xrather thanDriver version (12, 6) does not support X. For these I have just updated the tests to accept either string.I have confirmed this makes the tests pass in a local venv where I have installed
cuda-python==12.6.2-post1and a local checkout ofcuda_core. However, I don't think this is exercised in our CI. Should we add that?