Standardize use of Device arguments #1238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Andy-Jost
force-pushed
the
device-arg-cleanup
branch
from
5ea1aea to
fa327db
Compare
Andy-Jost
commented
Nov 14, 2025
|
|
||
| """ | ||
| __slots__ = ("_id", "_mr", "_has_inited", "_properties", "_uuid") | ||
| __slots__ = ("_id", "_memory_resource", "_has_inited", "_properties", "_uuid") |
Contributor
Author
There was a problem hiding this comment.
I renamed this to match a request in a recent change to _memory/_buffer.*
Andy-Jost
commented
Nov 14, 2025
Comment on lines
-989
to
-1003
| # If the device is in TCC mode, or does not support memory pools for some other reason, | ||
| # use the SynchronousMemoryResource which does not use memory pools. | ||
| with nogil: | ||
| HANDLE_RETURN( | ||
| cydriver.cuDeviceGetAttribute( | ||
| &attr, cydriver.CUdevice_attribute.CU_DEVICE_ATTRIBUTE_MEMORY_POOLS_SUPPORTED, dev_id | ||
| ) | ||
| ) | ||
| if attr == 1: | ||
| from cuda.core.experimental._memory import DeviceMemoryResource | ||
| device._mr = DeviceMemoryResource(dev_id) | ||
| else: | ||
| from cuda.core.experimental._memory import _SynchronousMemoryResource | ||
| device._mr = _SynchronousMemoryResource(dev_id) | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Moved to @property memory_resource (lazy init). This was resulting in a circularity with DeviceMemoryResource using Device.
…public APIs taking a device to accept either.
Andy-Jost
force-pushed
the
device-arg-cleanup
branch
from
fa327db to
267b268
Compare
Contributor
Author
|
/ok to test 267b268 |
This comment has been minimized.
This comment has been minimized.
leofang
approved these changes
Nov 15, 2025
leofang
added
enhancement
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Standardizes the way device arguments are accepted in public APIs. Previously, some functions could accept either a
Deviceorintrepresenting a device ordinal, whereas other would accept only an ordinal. This change updates everything to accept either.Also, rather than use
getattrto convert argument, this change usesDevice(arg)to convert any supported argument to a device (or raise an exception), matching the wayStreamarguments are converted.