-
Notifications
You must be signed in to change notification settings - Fork 223
Expand Windows test matrix to reproduce and fix nvbugs 5630448 #1242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
leofang
merged 25 commits into
NVIDIA:main
from
leofang:copilot/move-install-gpu-driver-script
Nov 18, 2025
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
f92ee6c
Initial plan
Copilot 5e08b07
Move install_gpu_driver.ps1 to ci/tools and update call sites
Copilot 2219f3b
Update install_gpu_driver.ps1 to support GPU type detection and drive…
Copilot de5b109
Make nightly sections empty in ci/test-matrix.json
Copilot 585e184
Expand Windows test matrix with driver mode support
Copilot de42011
Wire driver mode from test-matrix.json into Windows workflow
Copilot 35fa159
Update install_gpu_driver.ps1 to match CCCL implementation with drive…
Copilot da32f6c
Simplify driver mode handling per review feedback
Copilot a4a65ad
Use GPU_TYPE env var instead of parsing JOB_RUNNER
Copilot 16b0e3f
ensure each GPU kind are tested under two modes
leofang f789922
fix arch coverage
leofang f2ffbb1
make script more flexible; ensure cover 6 different GPUs, each with 2…
leofang 0293947
Add driver mode verification and change v100 to rtxpro6000 for CUDA 13
Copilot 1706a06
fix
leofang 2393b68
merge
leofang e363f0e
ensure using CTK 12.x with V100 + driver mode check can fail
leofang 3370245
fix syntax
leofang c7abbdf
avoid testing Quadro + WDDM; make driver mode show up in pipeline names
leofang 7dc0f91
add missing `test-cu12-ft` dep group
leofang 85c0059
fix VMM on Windows
leofang f716719
Merge branch 'fix_vmm' into copilot/move-install-gpu-driver-script
leofang ca1aa74
[pre-commit.ci] auto code formatting
pre-commit-ci[bot] 3781575
RTX cards cannot run MCDM, switch back to L4 for now
leofang da63359
fix silly typo
leofang 6c8cbcb
fix stupid negation
leofang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. FYI @alliepiper I backported your changes in CCCL to here 😋 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| # Install the driver | ||
| function Install-Driver { | ||
|
|
||
| # Set the correct URL, filename, and arguments to the installer | ||
| # This driver is picked to support Windows 11 & CUDA 13.0 | ||
| $version = '581.15' | ||
|
|
||
| # Get GPU type from environment variable | ||
| $gpu_type = $env:GPU_TYPE | ||
|
|
||
| $data_center_gpus = @('a100', 'h100', 'l4', 't4', 'v100', 'rtxa6000', 'rtx6000ada') | ||
| $desktop_gpus = @('rtx2080', 'rtx4090', 'rtxpro6000') | ||
|
|
||
| if ($data_center_gpus -contains $gpu_type) { | ||
| Write-Output "Data center GPU detected: $gpu_type" | ||
| $filename="$version-data-center-tesla-desktop-winserver-2022-2025-dch-international.exe" | ||
| $server_path="tesla/$version" | ||
| } elseif ($desktop_gpus -contains $gpu_type) { | ||
| Write-Output "Desktop GPU detected: $gpu_type" | ||
| $filename="$version-desktop-win10-win11-64bit-international-dch-whql.exe" | ||
| $server_path="Windows/$version" | ||
| } else { | ||
| Write-Output "Unknown GPU type: $gpu_type" | ||
| exit 1 | ||
| } | ||
|
|
||
| $url="https://us.download.nvidia.com/$server_path/$filename" | ||
| $filepath="C:\NVIDIA-Driver\$filename" | ||
|
|
||
| Write-Output "Installing NVIDIA driver version $version for GPU type $gpu_type" | ||
| Write-Output "Download URL: $url" | ||
|
|
||
| # Silent install arguments | ||
| $install_args = '/s /noeula /noreboot'; | ||
|
|
||
| # Create the folder for the driver download | ||
| if (!(Test-Path -Path 'C:\NVIDIA-Driver')) { | ||
| New-Item -Path 'C:\' -Name 'NVIDIA-Driver' -ItemType 'directory' | Out-Null | ||
| } | ||
|
|
||
| # Download the file to a specified directory | ||
| # Disabling progress bar due to https://github.com/GoogleCloudPlatform/compute-gpu-installation/issues/29 | ||
| $ProgressPreference_tmp = $ProgressPreference | ||
| $ProgressPreference = 'SilentlyContinue' | ||
| Write-Output 'Downloading the driver installer...' | ||
| Invoke-WebRequest $url -OutFile $filepath | ||
| $ProgressPreference = $ProgressPreference_tmp | ||
| Write-Output 'Download complete!' | ||
|
|
||
| # Install the file with the specified path from earlier | ||
| Write-Output 'Running the driver installer...' | ||
| Start-Process -FilePath $filepath -ArgumentList $install_args -Wait | ||
| Write-Output 'Done!' | ||
|
|
||
| # Handle driver mode configuration | ||
| # This assumes we have the prior knowledge on which GPU can use which mode. | ||
| $driver_mode = $env:DRIVER_MODE | ||
| if ($driver_mode -eq "WDDM") { | ||
| Write-Output "Setting driver mode to WDDM..." | ||
| nvidia-smi -fdm 0 | ||
| } elseif ($driver_mode -eq "TCC") { | ||
| Write-Output "Setting driver mode to TCC..." | ||
| nvidia-smi -fdm 1 | ||
| } elseif ($driver_mode -eq "MCDM") { | ||
| Write-Output "Setting driver mode to MCDM..." | ||
| nvidia-smi -fdm 2 | ||
| } else { | ||
| Write-Output "Unknown driver mode: $driver_mode" | ||
| exit 1 | ||
| } | ||
| pnputil /disable-device /class Display | ||
| pnputil /enable-device /class Display | ||
| # Give it a minute to settle: | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: moment (not minute) |
||
| Start-Sleep -Seconds 5 | ||
| } | ||
|
|
||
| # Run the functions | ||
| Install-Driver | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.