-
Notifications
You must be signed in to change notification settings - Fork 223
Update external library bindings #1243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
|
Q: Should we turn this function into a no-op (or remove it) to confirm the string fix? cuda-python/cuda_bindings/tests/test_cufile.py Lines 124 to 135 in 6ed6f6c
|
|
@leofang: WRT the "to-be-backported" label... do we usually backport these non-runtime/non-driver changes?
Yeah, I was just thinking the same thing. |
|
/ok to test |
Yes. We backport all bug fixes and enhancements to the 12.9 branch. For this PR since the diff is simple (not touching GHA files or build system), the bot can automatically backport it after the PR is merged. |
Ah got it. That was the source of my confusion. |
Hopefully #1199 can help eliminate the confusion 🙂 |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 12.9.x
git worktree add -d .worktree/backport-1243-to-12.9.x origin/12.9.x
cd .worktree/backport-1243-to-12.9.x
git switch --create backport-1243-to-12.9.x
git cherry-pick -x 1a118b746f8cad978845fad000572205abc604b1 |
|
This updates external (nvvm, nvjitlink and cufile) based on a few bugfixes. This wraps up 3 separate changes:
Fix a race condition where the init function could be called multiple times (increasing startup times)
Adds
cdef _get_ptrto class wrappers as a way to get a pointer to the underlying buffer without making a Python call (this is largely in support of future work to refactor how the buffer is allocated, in support of the future NVML bindings) -- In this case, there are no functions here that make use of_get_ptr, but since they aren't exposed, Cython generates astaticC function which the linker will remove because no one uses it. For example:UnicodeDecodeError.