You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NVML bindings are so large that they are hitting this bug, which was fixed in Cython 3.2. I'm upgrading to Cython 3.2 here to see if that breaks anything in our CI.
From another conversation with @vyasr, Cython 3.2 may have a bug affecting free-threaded builds, fixed by this PR, not yet released. The cuda-bindings CI is unlikely to pick up this bug, which still may have real consequences for our users if they are unlucky.
Another note -- the workaround suggested by the Cython team (to increase sys.maxrecursionlimit) doesn't work for the NVML bindings -- they are too large. So I do think we need this fixed "the right way".
Re free threaded builds, is there anything we can do other than simply wait for the fix to land? I suspect we have zero user using our free-threaded builds at the moment.
Re free threaded builds, is there anything we can do other than simply wait for the fix to land? I suspect we have zero user using our free-threaded builds at the moment.
Yeah, given we don't expect it to affect many, we could put a note in the "known issues". I'm not sure how best to word it -- it's sort of "if you are using a lot of threads on a free threaded build, it could segfault", but that's kind of par for the course anyway right now...?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NVML bindings are so large that they are hitting this bug, which was fixed in Cython 3.2. I'm upgrading to Cython 3.2 here to see if that breaks anything in our CI.