feat: add from_* style constructor classmethods to StridedMemoryView and deprecate __init__ constructor
#1250
Conversation
…and deprecate `__init__` constructor
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
|
/ok to test |
|
| warnings.warn( | ||
| f"Constructing a {clsname} directly from a DLPack-supporting object is deprecated; " | ||
| "Use `StridedMemoryView.from_dlpack` or `StridedMemoryView.from_any_interface` instead." | ||
| ) |
There was a problem hiding this comment.
Can we make this a FutureWarning (https://docs.python.org/3/library/exceptions.html#FutureWarning) or whatever warning type is most appropriate for this deprecation?
There was a problem hiding this comment.
I think the one we want is DeprecationWarning. Those are usually off by default, but tools like pytest will collect and display them at the end, so they get shown to developers using the library during their development rather than to "end users". FutureWarning is always on, so is meant for non-developers to see. (Think of like a data processing script that will require the user to change the format of their data in the future...) Fuzzy boundaries between those, of course.
leofang
added
P0
5 participants
Redo of #1224 without breaking changes.