-
Notifications
You must be signed in to change notification settings - Fork 226
Cythonize device memory resource attributes #1274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/ok to test 74c6611 |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, this is awesome! Please disregard my comment on #1272. I didn't see this before; and I didn't look around enough to realize it can be done this elegantly.
Andy-Jost
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together, Leo. This looks like the right approach to me.
|
Thanks guys! Merging. |
|
Description
There are a few pure Python constructions that are getting in the way, and those also forced us to use a single value type (was
intand being changed touint64_tin #1272). We have LLM now so we really should just spell it out once and tweak them quickly manually, like what we do for device attributes and program options.Before (
main):After this PR:
By construction this also fixes https://github.com/NVIDIA/cuda-python-private/issues/197.
Checklist