test: replace cuda driver, device, and context setup with fixtures where relevant #1293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
kkraus14
reviewed
Dec 2, 2025
kkraus14
approved these changes
Dec 2, 2025
cpcloud
force-pushed
the
cuda-bindings-fixtures
branch
from
54dc267 to
ca10214
Compare
Contributor
Author
|
/ok to test |
kkraus14
approved these changes
Dec 2, 2025
leofang
reviewed
Dec 2, 2025
|
|
||
| @pytest.fixture(scope="module") | ||
| def cuda_driver(): | ||
| (err,) = cuda.cuInit(0) |
Member
There was a problem hiding this comment.
FWIW cuInit cannot be undone once it's called. Might as well make it scope='session'.
Contributor
Author
There was a problem hiding this comment.
Sounds good, I will put up a follow-up for that in a bit.
|
Member
|
LGTM too! Thanks, Phillip! |
leofang
added
enhancement
Contributor
Author
|
This should help us be more confident about pytest-randomly usage inside cuda-bindings. I will look into factoring out fixtures where possible in cuda-core as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factor out repetitive cuda setup in
cuda_bindingsinto pytest fixtures.