Skip to content

Conversation

@ksimpson-work
Copy link
Contributor

close #362

@ksimpson-work ksimpson-work added P0 High priority - Must do! cuda.bindings Everything related to the cuda.bindings module labels Jan 13, 2025
@ksimpson-work ksimpson-work self-assigned this Jan 13, 2025
@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Jan 13, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Copy link
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Keenan! Could you also add a similar note on this to the 12.x.y binding release note? (We should also highlight that nvjitlink bindings are added, if we haven't done so already!)

@ksimpson-work
Copy link
Contributor Author

@leofang I just looked and it seems to be there already! Under highlights:
"- Add bindings for nvJitLink. It requires nvJitLink from CUDA 12.3 or above."

Copy link
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's trigger the doc build.

@leofang
Copy link
Member

leofang commented Jan 13, 2025

/ok to test

@leofang
Copy link
Member

leofang commented Jan 14, 2025

/ok to test

@leofang leofang merged commit 09a1f5d into NVIDIA:main Jan 15, 2025
79 checks passed
@github-actions
Copy link

Backport failed because this pull request contains merge commits. You can either backport this pull request manually, or configure the action to skip merge commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda.bindings Everything related to the cuda.bindings module P0 High priority - Must do!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document CTK version compatibility for nvJitLink

3 participants