Improve #789: Remove cyclical dependency between cuda.bindings.{driver|runtime} and c.b.utils

[mdboom]

Rather than having bindings.utils._get_handle.pyx depend on driver and runtime and define the getters there, this flips things so driver and runtime register their own handlers.

While this doesn't resolve all cyclical imports as required by #789, this was a fairly straightforward change that improves import times by about 10%:

• Cold import time of bindings.cuda.nvrtc before this change: 59.1 ms +- 1.7 ms
• Cold import time of bindings.cuda.nvrtc after this change: 53.8 ms +- 2.4 ms
• Baseline Python startup: 8.36 ms +- 0.31 ms

(This was measured using this pyperf benchmark, starting with a fresh Python process each time.)

This is generated based on changes to cython_gen submitted in the private repo: https://github.com/NVIDIA/cuda-python-private/pull/131

[copy-pr-bot]

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

[Copilot]

Pull Request Overview

This PR refactors the CUDA handle getter architecture to eliminate cyclical dependencies between the cuda.bindings.{driver|runtime} and cuda.bindings.utils modules. Instead of having _get_handle.pyx depend on driver and runtime modules and centrally define all getters, the change flips the dependency so that driver and runtime modules register their own handle getters with the utils module.

• Removes the centralized _get_handle.pyx.in file that created cyclical imports
• Moves handle getter registration to individual driver and runtime modules
• Introduces a registration mechanism in utils module for type-specific handle getters

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
cuda_bindings/cuda/bindings/utils/_get_handle.pyx.in	Entire file removed - eliminated centralized handle getter definitions
cuda_bindings/cuda/bindings/utils/__init__.py	Added registration mechanism and moved get_cuda_native_handle function here
cuda_bindings/cuda/bindings/runtime.pyx.in	Added handle getter registration function and call to register runtime types
cuda_bindings/cuda/bindings/nvrtc.pyx.in	Added utils import (minimal change for dependency alignment)
cuda_bindings/cuda/bindings/driver.pyx.in	Added handle getter registration function and call to register driver types

Comments suppressed due to low confidence (2)

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[mdboom]

/ok to test

[leofang]

it seems this is unused and can be purged

Suggested change

from cuda.bindings import utils

[mdboom]

/ok to test

[leofang]

Thanks, Mike! LGTM!

[mdboom]

/ok to test

[leofang]

/ok to test 15eeb07

[mdboom]

@leofang: As far as workflow goes, should I merge this now or wait until the cython-gen changes that generated them are approved also?

[rwgk]

@leofang: As far as workflow goes, should I merge this now or wait until the cython-gen changes that generated them are approved also?

We often merge here before merging the cython-gen changes. I'd say go ahead.

It's ideal to merge the cython-gen changes shortly before or after. I think you can even merge them without approval, although I generally feel most comfortable if I get an explicit approval there, too.

[leofang]

@leofang: As far as workflow goes, should I merge this now or wait until the cython-gen changes that generated them are approved also?

We often merge here before merging the cython-gen changes. I'd say go ahead.

It's ideal to merge the cython-gen changes shortly before or after. I think you can even merge them without approval, although I generally feel most comfortable if I get an explicit approval there, too.

Thanks, Mike! Getting approval is always good. I did not merge last week because I wanted to push out the patch release first, and we can't keep asking Peter to re-spin the test every time we update the binding code. We should keep the changes minimal. After we pushed it out this morning, we are un-freezed and resume merging.

Keep in mind that we haven't backported #835 to the codegens, so right now after regenerating the output will deviate from what's in the public. I am very occupied today and likely tomorrow due to the remaining CuPy release works, I hope we can get it done soon.

[github-actions]

Doc Preview CI
Preview removed because the pull request was closed or merged.