Skip to content

Conversation

cpcloud
Copy link
Contributor

@cpcloud cpcloud commented Sep 10, 2025

This PR implements proper None checks using is/is not, contains code regenerated from https://github.com/NVIDIA/cuda-python-private/pull/146.

@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Sep 10, 2025

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@cpcloud
Copy link
Contributor Author

cpcloud commented Sep 10, 2025

/ok to test

@github-actions

This comment has been minimized.

Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Thoughts:

  • In theory we could undo the corresponding change in the code generator, and still run pre-commit against the code generator code,
  • but I think it's better to merge this PR, so we don't have to think so much what we're doing where.

@leofang
Copy link
Member

leofang commented Sep 10, 2025

@cpcloud feel free to merge, one thing that's technically missing is a release note entry, but for this one it is up to you if you wanna document it or not

@leofang
Copy link
Member

leofang commented Sep 10, 2025

Also plz regenerate and backport to 12.9.x

@leofang leofang added enhancement Any code-related improvements P1 Medium priority - Should do cuda.bindings Everything related to the cuda.bindings module labels Sep 10, 2025
@leofang leofang added this to the cuda-python 13-next, 12-next milestone Sep 10, 2025
@cpcloud
Copy link
Contributor Author

cpcloud commented Sep 15, 2025

Is there a checklist of things that must be done when a PR is merged that ideally we can work towards automating?

@cpcloud
Copy link
Contributor Author

cpcloud commented Sep 15, 2025

backport is here #970

@leofang
Copy link
Member

leofang commented Sep 15, 2025

Is there a checklist of things that must be done when a PR is merged that ideally we can work towards automating?

There is a PR template which is ignored in this PR, though I don't think it matters much for the team members IMHO; most of time I just let it populate the text but does not read them either. I'd love to have more automation, but there are cases for which having a release note entry is too noisy, so an escape hatch is also needed.

@cpcloud
Copy link
Contributor Author

cpcloud commented Sep 15, 2025

I see. It looks like the PR template could use some TLC.

@leofang
Copy link
Member

leofang commented Sep 15, 2025

Yeah. For example, another thing that would be great to have is a backport reminder when a PR touches cuda-bindings on main, but I dunno how the PR template could help. Right now I just manually go through merged PRs every Sunday and check which one hasn't been backported 🤷 (This is tracked in #965 FWIW.)

@cpcloud cpcloud merged commit e06b299 into NVIDIA:main Sep 15, 2025
52 checks passed
@github-actions
Copy link

Doc Preview CI
Preview removed because the pull request was closed or merged.

@cpcloud cpcloud deleted the fix-none-checks-new-codegen branch September 15, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda.bindings Everything related to the cuda.bindings module enhancement Any code-related improvements P1 Medium priority - Should do

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants