-
Notifications
You must be signed in to change notification settings - Fork 217
Regen bindings to use is
/is not
None
instead of equality checks
#961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
/ok to test |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thoughts:
- In theory we could undo the corresponding change in the code generator, and still run pre-commit against the code generator code,
- but I think it's better to merge this PR, so we don't have to think so much what we're doing where.
@cpcloud feel free to merge, one thing that's technically missing is a release note entry, but for this one it is up to you if you wanna document it or not |
Also plz regenerate and backport to 12.9.x |
Is there a checklist of things that must be done when a PR is merged that ideally we can work towards automating? |
backport is here #970 |
There is a PR template which is ignored in this PR, though I don't think it matters much for the team members IMHO; most of time I just let it populate the text but does not read them either. I'd love to have more automation, but there are cases for which having a release note entry is too noisy, so an escape hatch is also needed. |
I see. It looks like the PR template could use some TLC. |
Yeah. For example, another thing that would be great to have is a backport reminder when a PR touches cuda-bindings on main, but I dunno how the PR template could help. Right now I just manually go through merged PRs every Sunday and check which one hasn't been backported 🤷 (This is tracked in #965 FWIW.) |
|
This PR implements proper None checks using
is
/is not
, contains code regenerated from https://github.com/NVIDIA/cuda-python-private/pull/146.