Skip to content

Conversation

cpcloud
Copy link
Contributor

@cpcloud cpcloud commented Sep 19, 2025

Moves cibuildwheel config out of github actions and into corresponding pyproject.toml files.

@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Sep 19, 2025

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@cpcloud
Copy link
Contributor Author

cpcloud commented Sep 19, 2025

/ok to test

1 similar comment
@cpcloud
Copy link
Contributor Author

cpcloud commented Sep 19, 2025

/ok to test

@cpcloud cpcloud force-pushed the move-cibuildwheel-config-to-pyproject-toml branch from 4bb5410 to 261651b Compare September 19, 2025 14:33
@cpcloud
Copy link
Contributor Author

cpcloud commented Sep 19, 2025

/ok to test

2 similar comments
@cpcloud
Copy link
Contributor Author

cpcloud commented Sep 19, 2025

/ok to test

@cpcloud
Copy link
Contributor Author

cpcloud commented Sep 19, 2025

/ok to test

@cpcloud cpcloud force-pushed the move-cibuildwheel-config-to-pyproject-toml branch from 1ad4b74 to c883a26 Compare September 19, 2025 16:52
@cpcloud
Copy link
Contributor Author

cpcloud commented Sep 19, 2025

/ok to test

2 similar comments
@cpcloud
Copy link
Contributor Author

cpcloud commented Sep 19, 2025

/ok to test

@cpcloud
Copy link
Contributor Author

cpcloud commented Sep 19, 2025

/ok to test

@cpcloud cpcloud force-pushed the move-cibuildwheel-config-to-pyproject-toml branch from c9c8dd2 to 3496530 Compare September 19, 2025 16:54
@cpcloud
Copy link
Contributor Author

cpcloud commented Sep 19, 2025

/ok to test

@github-actions

This comment has been minimized.

@cpcloud cpcloud force-pushed the move-cibuildwheel-config-to-pyproject-toml branch from f0dc073 to b748718 Compare September 22, 2025 14:28
@cpcloud
Copy link
Contributor Author

cpcloud commented Sep 22, 2025

/ok to test

@cpcloud cpcloud requested a review from rwgk September 22, 2025 15:21
rwgk
rwgk previously approved these changes Sep 22, 2025
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but caveat: I'm more learning than reviewing when looking through this PR.

@cpcloud cpcloud force-pushed the move-cibuildwheel-config-to-pyproject-toml branch from b748718 to cf7d2d8 Compare September 23, 2025 12:17
@cpcloud
Copy link
Contributor Author

cpcloud commented Sep 23, 2025

/ok to test

@cpcloud
Copy link
Contributor Author

cpcloud commented Sep 23, 2025

@kkraus14 Can you give this another review?

@kkraus14 kkraus14 merged commit 5fb83a1 into NVIDIA:main Sep 23, 2025
70 checks passed
@github-actions
Copy link

Doc Preview CI
Preview removed because the pull request was closed or merged.

@cpcloud cpcloud deleted the move-cibuildwheel-config-to-pyproject-toml branch September 23, 2025 16:32
@leofang leofang mentioned this pull request Sep 30, 2025
2 tasks
@leofang
Copy link
Member

leofang commented Oct 3, 2025

For posterity: a follow-up discussion happened here: https://github.com/NVIDIA/cuda-python/pull/1041/files#r2388712078

@leofang leofang added enhancement Any code-related improvements CI/CD CI/CD infrastructure labels Oct 3, 2025
@leofang leofang added this to the cuda.core beta 7 milestone Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD CI/CD infrastructure enhancement Any code-related improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants