refactor(deps): organize test and dev dependencies using dependency groups #995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
cpcloud
force-pushed
the
move-test-deps-to-group
branch
from
4065f5c to
0cd8a6a
Compare
|
/ok to test |
1 similar comment
|
/ok to test |
cpcloud
force-pushed
the
move-test-deps-to-group
branch
from
b57568a to
c23fb7c
Compare
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
cpcloud
force-pushed
the
move-test-deps-to-group
branch
from
c23fb7c to
dbf1ced
Compare
|
/ok to test |
cpcloud
force-pushed
the
move-test-deps-to-group
branch
from
dbf1ced to
256f679
Compare
|
/ok to test |
cpcloud
force-pushed
the
move-test-deps-to-group
branch
from
256f679 to
d37eeba
Compare
|
/ok to test |
cpcloud
force-pushed
the
move-test-deps-to-group
branch
from
d37eeba to
17ad016
Compare
|
/ok to test |
cpcloud
force-pushed
the
move-test-deps-to-group
branch
from
17ad016 to
0e03477
Compare
|
/ok to test |
kkraus14
reviewed
Sep 30, 2025
kkraus14
previously approved these changes
Oct 1, 2025
kkraus14
added
CI/CD
cpcloud
force-pushed
the
move-test-deps-to-group
branch
from
0e03477 to
86ad97a
Compare
|
/ok to test |
kkraus14
approved these changes
Oct 1, 2025
|
|
It would be nice to document how this works for internal/external developers as well as QA. Let me create an issue to follow up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I didn't open an issue as it seemed better to discuss this in the context of
actual code instead of hypotheticals.
This PR reorganizes the
cuda_*packages to usedependency-groupsto manage test anddevelopment dependencies.
optional-dependencies(pip extras, really) was, for a long time, the only wayto spell this kind of thing, but since PEP 735, and its corresponding
implementation in
pip25.1
there's a better way, which among other things hides these development-only
dependencies from vanilla installations and makes it clear by reading
a
pyproject.tomlwhat is development-only and what isn't.I tried to catch all the scripts that are using this, but seeing as how our CI steps are distributed
across a number of scripts which contains lots of implicit references to environment variables, I may
have missed some. Let's see what CI says.