chore(ci): cleanup unused references and improve ci logging

- Changed DRY_RUN to be configurable via environment variable.
- Introduced PLACEHOLDER_VERSION for versioning consistency.
- Simplified console log handling in various Vite configurations by extracting logic into a dedicated function.
- Removed unused imports and improved button example interactions in the documentation.
- Fixed typos in test descriptions for better clarity.

Signed-off-by: Cory Rylan <crylan@nvidia.com>

Author: coryrylan

projects/code/vitest.config.ts

@@ -22,10 +22,7 @@ export default mergeConfig(libraryTestConfig, {
       'highlight.js/lib/languages/typescript',
       'highlight.js/lib/languages/xml',
       'highlight.js/lib/languages/yaml'
-    ],
-    rolldownOptions: {
-      mainFields: ['module', 'main']
-    }
+    ]
   },
   test: {
     include: ['./src/**/*.test.ts'],

projects/core/src/button/button.examples.ts

@@ -13,8 +13,6 @@ export default {
   component: 'nve-button'
 };
 
-declare const __ELEMENTS_REPO_BASE_URL__: string;
-
 /**
  * @summary Basic button component with standard appearance and behavior for primary user actions.
  */
@@ -120,20 +118,25 @@ export const Disabled = {
  */
 export const InvokerCommand = {
   render: () => html`
-    <img id="logo" src="${__ELEMENTS_REPO_BASE_URL__}/favicon.svg" alt="logo" style="width: 100px; height: 100px;" />
+    <nve-icon
+      id="rotation-target"
+      name="sparkles"
+      aria-label="sparkles icon"
+      style="inline-size: 100px; block-size: 100px;"
+    ></nve-icon>
     <section>
-      <nve-button commandfor="logo" command="--rotate-left">Rotate left</nve-button>
-      <nve-button commandfor="logo" command="--rotate-right">Rotate right</nve-button>
+      <nve-button commandfor="rotation-target" command="--rotate-left">Rotate left</nve-button>
+      <nve-button commandfor="rotation-target" command="--rotate-right">Rotate right</nve-button>
       <nve-button commandfor="popover" command="toggle-popover">toggle-popover</nve-button>
     </section>
     <nve-toggletip id="popover">popover</nve-toggletip>
     <script type="module">
-      const logo = document.getElementById('logo');
-      logo.addEventListener('command', (event) => {
-        if (event.command == '--rotate-left') {
-          logo.style.rotate = '-90deg';
-        } else if (event.command == '--rotate-right') {
-          logo.style.rotate = '90deg';
+      const target = document.getElementById('rotation-target');
+      target.addEventListener('command', (event) => {
+        if (event.command === '--rotate-left') {
+          target.style.rotate = '-90deg';
+        } else if (event.command === '--rotate-right') {
+          target.style.rotate = '90deg';
         }
       });
     </script>

projects/core/src/internal/base/button.test.ts

@@ -233,7 +233,7 @@ describe('base button', () => {
     expect((await event).type).toBe('submit');
   });
 
-  it('should not ineract with form elements if type button', async () => {
+  it('should not interact with form elements if type button', async () => {
     submitButtonInForm.type = 'button';
     await elementIsStable(submitButtonInForm);
     const o = { f: () => null };
@@ -273,7 +273,7 @@ describe('base button', () => {
     expect(o.f).not.toHaveBeenCalled();
   });
 
-  it('should not interact with form elements if disabeld', async () => {
+  it('should not interact with form elements if disabled', async () => {
     submitButtonInForm.disabled = true;
     await elementIsStable(submitButtonInForm);
 

projects/core/src/internal/controllers/state-current.controller.test.ts

@@ -76,7 +76,7 @@ describe('state-current.controller', () => {
     expect(element.matches(':state(current)')).toBe(false);
   });
 
-  it('should appply aria-current="page" if a current anchor', async () => {
+  it('should apply aria-current="page" if a current anchor', async () => {
     const a = document.createElement('a');
     a.href = '#';
     element.appendChild(a);

projects/core/src/internal/controllers/state-selected.controller.test.ts

@@ -76,7 +76,7 @@ describe('state-selected.controller', () => {
     expect(element.matches(':state(selected)')).toBe(false);
   });
 
-  it('should appply aria-current="page" if a selected anchor', async () => {
+  it('should apply aria-current="page" if a selected anchor', async () => {
     const a = document.createElement('a');
     a.href = '#';
     element.appendChild(a);

projects/core/src/internal/controllers/type-submit.controller.test.ts

@@ -166,7 +166,7 @@ describe('type-submit.controller', () => {
     expect((await event).type).toBe('reset');
   });
 
-  it('should not ineract with form elements if type button', async () => {
+  it('should not interact with form elements if type button', async () => {
     submitButtonInForm.type = 'button';
     await elementIsStable(submitButtonInForm);
     const o = { f: () => null };

projects/internals/ci/cache-validate.js

@@ -19,7 +19,7 @@ async function validateCache(task) {
   const parallel = process.env.WIREIT_PARALLEL ? ` WIREIT_PARALLEL=${process.env.WIREIT_PARALLEL}` : '';
   // Only pass PAGES_BASE_URL when set so Wireit sees same env as first run (default "/elements/" for site:build)
   const pagesBaseUrl = process.env.PAGES_BASE_URL !== undefined ? ` PAGES_BASE_URL=${process.env.PAGES_BASE_URL}` : '';
-  const { stdout } = await new Promise(resolve =>
+  await new Promise(resolve =>
     exec(
       `WIREIT_DEBUG_LOG_FILE=.wireit-cache WIREIT_LOGGER=simple${pagesBaseUrl}${parallel} pnpm run ${task}`,
       (stderr, stdout) => resolve({ stdout, stderr })

projects/internals/vite/src/configs/axe.js

@@ -3,6 +3,7 @@ import process from 'process';
 import { readFileSync } from 'node:fs';
 import { resolve } from 'node:path';
 import { playwright } from '@vitest/browser-playwright';
+import { hideExpectedTestConsoleMessage } from './console.js';
 
 const watch = process.argv.findIndex(i => i === '--watch') !== -1;
 const coverage = process.argv.findIndex(i => i === '--coverage') !== -1;
@@ -69,13 +70,7 @@ export const libraryAxeTestConfig = {
       junit: './coverage/axe/junit.xml',
       json: './coverage/axe/summary.json'
     },
-    onConsoleLog(log) {
-      if (log.includes('scheduled an update')) return false;
-      if (log.includes('Lit is in dev mode')) return false;
-      if (log.includes('@nve: ')) return false;
-      if (log.startsWith('[Error: Expected error]')) return false;
-      if (log.startsWith('Ignored')) return false;
-    },
+    onConsoleLog: hideExpectedTestConsoleMessage,
     setupFiles: ['@internals/vite/setup/axe.js'], // todo: this should be project specific
     browser: {
       isolate: false,

projects/internals/vite/src/configs/console.js

@@ -0,0 +1,18 @@
+const expectedTestConsoleMessages = [
+  'plugin vite-plugin-virtual-html',
+  'ElementInternals.checkValidity() was called on the server.This method always returns true.'
+];
+
+function isExpectedTestConsoleMessage(log) {
+  if (expectedTestConsoleMessages.some(message => log.includes(message))) {
+    return true;
+  }
+
+  return false;
+}
+
+export function hideExpectedTestConsoleMessage(log) {
+  if (isExpectedTestConsoleMessage(log)) {
+    return false;
+  }
+}

projects/internals/vite/src/configs/lighthouse.js

@@ -1,4 +1,4 @@
-import process from 'process';
+import { hideExpectedTestConsoleMessage } from './console.js';
 
 /** @type {import('vite').UserConfig} */
 export const libraryLighthouseTestConfig = {
@@ -9,11 +9,7 @@ export const libraryLighthouseTestConfig = {
     isolate: false,
     maxWorkers: 1,
     fileParallelism: false,
-    onConsoleLog(log) {
-      if (log.includes('plugin vite-plugin-virtual-html')) {
-        return false;
-      }
-    },
+    onConsoleLog: hideExpectedTestConsoleMessage,
     reporters: [
       'default',
       'junit',