Skip to content

Conversation

@elezar
Copy link
Member

@elezar elezar commented Nov 20, 2023

This has been adapted from https://gitlab.com/nvidia/cloud-native/go-nvlib/-/merge_requests/22

The changes have been rebased on main.

Closed #11

@elezar elezar requested a review from klueska November 20, 2023 20:51
Telemaco019 and others added 2 commits November 20, 2023 21:52
Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar
Copy link
Member Author

elezar commented Nov 20, 2023

@Telemaco019 I have migrated your MR from https://gitlab.com/nvidia/cloud-native/go-nvlib/-/merge_requests/22 here.

Note, that we require that your commits be signed-off. Please update them if you want this merged.

Sorry for the delay here.

@elezar elezar removed the request for review from klueska November 20, 2023 20:54
@elezar elezar self-assigned this Nov 20, 2023
@Telemaco019
Copy link

@Telemaco019 I have migrated your MR from https://gitlab.com/nvidia/cloud-native/go-nvlib/-/merge_requests/22 here.

Note, that we require that your commits be signed-off. Please update them if you want this merged.

Sorry for the delay here.

Hi @elezar, don't worry about the delay :)
I don't have write permissions on this repo, so I've just opened another PR from my fork with the signed-off commit: #13

@elezar elezar closed this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add method CreateGpuInstance(Info *GpuInstanceProfileInfo) to nvml.Device

3 participants