Skip to content

Conversation

@guptaNswati
Copy link
Contributor

@guptaNswati guptaNswati commented Feb 6, 2025

@guptaNswati
Copy link
Contributor Author

@ArangoGutierrez i see that the samples binaries are getting built from here https://github.com/NVIDIA/k8s-samples/blob/main/deployments/container/Dockerfile.ubuntu#L38

which means i can just add the simpleMultiGPU sample in the CI yaml and it will be built automatically. All the dockerfile seems to be archived and only for reference.

@guptaNswati guptaNswati changed the title Draft: Add cuda mps simpleMultiGPU sample Add cuda mps simpleMultiGPU sample Feb 7, 2025
Signed-off-by: Swati Gupta <swatig@nvidia.com>
@copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 3, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Signed-off-by: Swati Gupta <swatig@nvidia.com>
@guptaNswati
Copy link
Contributor Author

/ok to test

Copy link
Member

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @guptaNswati. This looks good.

I noted that for "sample only tag" we're pushing: ghcr.io/nvidia/k8s-samples:devicequery-b5b1a425- for example which is not specific to this PR. Going to approve this and then we can have a look at what's going on there as a follow-up.

update: I take it back. It's line wrapping in the CI output. The string is being split on the - and the full string is actually:

pushing manifest for ghcr.io/nvidia/k8s-samples:devicequery-b5b1a425-ubuntu22.04@sha256:5fc67a28aecbd83f7c46671a16bcdffc61875a4740ff11d1b36909a7569232f3

@guptaNswati guptaNswati merged commit 004e23c into NVIDIA:main Mar 6, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants