Skip to content

Conversation

elezar
Copy link
Member

@elezar elezar commented Jul 9, 2025

This change updates the image publishing process for releases. It makes similar changes to those for the gpu-operator in NVIDIA/gpu-operator#1517.

@elezar elezar self-assigned this Jul 9, 2025
@elezar elezar added this to the v1.18.0 milestone Jul 9, 2025
@coveralls
Copy link

coveralls commented Jul 9, 2025

Pull Request Test Coverage Report for Build 16167016874

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 35.012%

Totals Coverage Status
Change from base Build 16146292168: 0.0%
Covered Lines: 4442
Relevant Lines: 12687

💛 - Coveralls

@ArangoGutierrez ArangoGutierrez requested a review from Copilot July 9, 2025 09:31
Copilot

This comment was marked as outdated.

elezar added 2 commits July 9, 2025 11:34
Since we no longer maintain two pipeline definitions, it is
simpler to maintain a single CI definition file.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar elezar force-pushed the integrate-ngc-automation branch from c1b5225 to a28e38a Compare July 9, 2025 09:34
Signed-off-by: Evan Lezar <elezar@nvidia.com>
@ArangoGutierrez ArangoGutierrez requested a review from Copilot July 9, 2025 09:38
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR integrates NGC automation into the image publishing pipeline by embedding previously shared CI configuration directly and adding new stages/jobs for rendering and publishing images to the NGC registry.

  • Inlines and duplicates former common CI steps from .common-ci.yml
  • Adds ngc-publish stage with .publish-images and publish-images-to-ngc jobs
  • Removes .common-ci.yml and updates .nvidia-ci.yml accordingly

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.nvidia-ci.yml Inlined common CI config; added NGC publish stages
.common-ci.yml Deleted shared CI template to consolidate config
Comments suppressed due to low confidence (3)

.nvidia-ci.yml:262

  • The variable IN_IMAGE_TAG is not defined in this job, which will cause the script to output an empty value. You need to set or pass this variable before usage.
      echo "${IN_IMAGE_TAG} ${OUT_IMAGE_TAG}" >> ${VERSION_FILE}

.nvidia-ci.yml:263

  • There's an extra trailing double-quote at the end of this line, which will cause a shell syntax error. Remove the extra quote.
      echo "${IN_IMAGE_TAG}-packaging ${OUT_IMAGE_TAG}-packaging" >> ${VERSION_FILE}"

@elezar elezar force-pushed the integrate-ngc-automation branch from a28e38a to 051fe94 Compare July 9, 2025 10:34
@elezar elezar requested a review from ArangoGutierrez July 9, 2025 10:34
@elezar elezar requested a review from ArangoGutierrez July 9, 2025 11:53
Comment on lines +272 to +273


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

nit

@elezar elezar merged commit a786a6d into NVIDIA:main Jul 9, 2025
16 checks passed
@elezar elezar deleted the integrate-ngc-automation branch July 9, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants