-
Notifications
You must be signed in to change notification settings - Fork 425
Integrate ngc automation #1181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate ngc automation #1181
Conversation
Pull Request Test Coverage Report for Build 16167016874Details
💛 - Coveralls |
Since we no longer maintain two pipeline definitions, it is simpler to maintain a single CI definition file. Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
c1b5225
to
a28e38a
Compare
Signed-off-by: Evan Lezar <elezar@nvidia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR integrates NGC automation into the image publishing pipeline by embedding previously shared CI configuration directly and adding new stages/jobs for rendering and publishing images to the NGC registry.
- Inlines and duplicates former common CI steps from
.common-ci.yml
- Adds
ngc-publish
stage with.publish-images
andpublish-images-to-ngc
jobs - Removes
.common-ci.yml
and updates.nvidia-ci.yml
accordingly
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
.nvidia-ci.yml | Inlined common CI config; added NGC publish stages |
.common-ci.yml | Deleted shared CI template to consolidate config |
Comments suppressed due to low confidence (3)
.nvidia-ci.yml:262
- The variable
IN_IMAGE_TAG
is not defined in this job, which will cause the script to output an empty value. You need to set or pass this variable before usage.
echo "${IN_IMAGE_TAG} ${OUT_IMAGE_TAG}" >> ${VERSION_FILE}
.nvidia-ci.yml:263
- There's an extra trailing double-quote at the end of this line, which will cause a shell syntax error. Remove the extra quote.
echo "${IN_IMAGE_TAG}-packaging ${OUT_IMAGE_TAG}-packaging" >> ${VERSION_FILE}"
a28e38a
to
051fe94
Compare
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
This change updates the image publishing process for releases. It makes similar changes to those for the
gpu-operator
in NVIDIA/gpu-operator#1517.