[no-relnote] Fix E2E matrix conditional #1202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 16465424032Details
💛 - Coveralls |
ArangoGutierrez
force-pushed
the
multiple_drivers_e2e_v2
branch
from
fe1c036 to
4e8fa02
Compare
ArangoGutierrez
commented
Jul 21, 2025
ArangoGutierrez
force-pushed
the
multiple_drivers_e2e_v2
branch
11 times, most recently
from
f7cd481 to
79faccf
Compare
Collaborator
Author
|
Ok, I think this PR fixes the matrix execution |
elezar
reviewed
Jul 22, 2025
elezar
reviewed
Jul 22, 2025
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
ArangoGutierrez
force-pushed
the
multiple_drivers_e2e_v2
branch
from
79faccf to
2b0ca5e
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the E2E workflow's matrix conditional logic to properly identify pull requests and non-main/release branches. The change improves the accuracy of the conditional used to exclude certain driver branch combinations in the test matrix.
- Renamed the matrix variable from
is_pull_requesttoisprfor better clarity - Updated the conditional logic to check for non-main branches that don't start with 'release-' instead of checking pull request refs
Comments suppressed due to low confidence (1)
.github/workflows/e2e.yaml:42
- The variable name 'ispr' is ambiguous and unclear. Consider using a more descriptive name like 'is_feature_branch' or 'exclude_expensive_tests' to better reflect what this variable represents.
ispr:
elezar
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.