Skip to content

[no-relnote] Rename Config to TopLevelConfigPath #1301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2025
Merged

[no-relnote] Rename Config to TopLevelConfigPath #1301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions cmd/nvidia-ctk-installer/container/container.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ const (
// Options defines the shared options for the CLIs to configure containers runtimes.
type Options struct {
DropInConfig string
// TODO: Rename to TopLevelConfig
Config string
Socket string
// TopLevelConfigPath stores the path to the top-level config for the runtime.
TopLevelConfigPath string
Socket string
// ExecutablePath specifies the path to the container runtime executable.
// This is used to extract the current config, for example.
// If a HostRootMount is specified, this path is relative to the host root
Expand Down Expand Up @@ -75,7 +75,7 @@ func (o Options) Unconfigure(cfg engine.Interface) error {
func (o Options) flush(cfg engine.Interface) error {
filepath := o.DropInConfig
if filepath == "" {
filepath = o.Config
filepath = o.TopLevelConfigPath
}
logrus.Infof("Flushing config to %v", filepath)
n, err := cfg.Save(filepath)
Expand Down
Loading
Loading