Skip to content

Conversation

@elezar
Copy link
Member

@elezar elezar commented Dec 3, 2025

Add a --no-all-device option to the nvidia-ctk cdi generate command to not generate an all device including the specs for all generated devices. This can also be set using the NVIDIA_CTK_CDI_GENERATE_NO_ALL_DEVICE environment variable.

Add a --no-all-device option to the nvidia-ctk cdi generate
command to not generate an `all` device including the specs
for all generated devices. This can also be set using the
NVIDIA_CTK_CDI_GENERATE_NO_ALL_DEVICE environment variable.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar elezar force-pushed the add-disable-all-device branch from c6814ff to f686b89 Compare December 3, 2025 13:45
@elezar elezar changed the title Allow opt-out of all CDI device when generating CDI specs Add --no-all-device option to nvidia-ctk cd generate Dec 3, 2025
@elezar elezar added this to the v1.19.0 milestone Dec 3, 2025
@coveralls
Copy link

coveralls commented Dec 3, 2025

Pull Request Test Coverage Report for Build 19895997516

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 37.675%

Totals Coverage Status
Change from base Build 19891238769: 0.02%
Covered Lines: 5183
Relevant Lines: 13757

💛 - Coveralls

Copy link
Collaborator

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

spec.WithPermissions(0644),
}

if !opts.noAllDevice {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the "no-all-device" is set the spec will be generated without the option of transform.WithName(allDeviceName)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants