Skip to content

Conversation

@elezar
Copy link
Member

@elezar elezar commented Jul 31, 2024

This adds a basic test that fails without the changes of #619

Against v1.16.0:

--- FAIL: TestNewNvmlMIGDiscoverer (0.00s)
    --- FAIL: TestNewNvmlMIGDiscoverer/#00 (0.00s)
        nvml_test.go:161:
                Error Trace:    /Users/elezar/src/container-toolkit/internal/platform-support/dgpu/nvml_test.go:161
                Error:          Target error should be in err chain:
                                expected: ""
                                in chain: "error getting placement info: error getting GPU minor: <nil>"
                                        "error getting GPU minor: <nil>"
                Test:           TestNewNvmlMIGDiscoverer/#00
FAIL

Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar elezar requested a review from cdesiniotis July 31, 2024 09:57
@elezar elezar self-assigned this Jul 31, 2024
@elezar elezar requested a review from tariq1890 July 31, 2024 15:10
@elezar elezar merged commit 122136f into NVIDIA:main Aug 1, 2024
@elezar elezar deleted the add-mig-cdi-test branch August 1, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants