Skip to content

Use empty string for default runtime-config-override #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Use empty string for default runtime-config-override #659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
852a7a6
Use empty string for default runtime-config-override
elezar Aug 19, 2024
6d7dd04
[no-relnote] Fix lint error in test
elezar Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/nvidia-ctk/runtime/configure/configure.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ func (m command) build() *cli.Command {
Name: "runtime-config-override",
Destination: &config.runtimeConfigOverrideJSON,
Usage: "specify additional runtime options as a JSON string. The paths are relative to the runtime config.",
Value: "{}",
Value: "",
EnvVars: []string{"RUNTIME_CONFIG_OVERRIDE"},
},
}
Expand Down
2 changes: 1 addition & 1 deletion internal/discover/mounts_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ func TestMounts(t *testing.T) {
lookup: &lookup.LocatorMock{
LocateFunc: func(s string) ([]string, error) {
if s == "error" {
return nil, fmt.Errorf(s)
return nil, fmt.Errorf("error")
Copy link
Contributor

@tariq1890 tariq1890 Aug 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: (Optional) If we are using constant strings, we can use the stdlib errors.New instead. Also we need a better error message than just error as it doesn't say much. I understand that it's a test case, but expressive error messages also help us better debug and trace unit test failures

Suggested change
return nil, fmt.Errorf("error")
return nil, fmt.Errorf("error")

Copy link
Member Author

@elezar elezar Aug 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are all valid points. Since this is a cherry-pick, I'm not going to address these here and would prefer to keep the functionality the same.

}
return []string{s}, nil
},
Expand Down