[no-relnote] Run e2e tests as reusable workflow #913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArangoGutierrez
added
the
testing
ArangoGutierrez
force-pushed
the
e2e_tests01
branch
3 times, most recently
from
b74e568 to
76b1b60
Compare
Collaborator
Author
|
Image check now looks like this: |
ArangoGutierrez
force-pushed
the
e2e_tests01
branch
3 times, most recently
from
2d33574 to
3cf3118
Compare
elezar
reviewed
Feb 10, 2025
deployments/container/native-only.mk
Outdated
| $(DEFAULT_PUSH_TARGET): | ||
| $(DOCKER) image inspect $(IMAGE) > /dev/null || $(DOCKER) pull $(IMAGE) | ||
| $(DOCKER) tag $(IMAGE) $(subst :$(IMAGE_TAG),:$(VERSION),$(IMAGE)) | ||
| endif |
elezar
reviewed
Feb 10, 2025
| - "pull-request/[0-9]+" | ||
| - main | ||
| - release-* | ||
| workflow_call: |
Member
There was a problem hiding this comment.
Should there not also be a change to image.yaml?
ArangoGutierrez
force-pushed
the
e2e_tests01
branch
3 times, most recently
from
03266c5 to
a251a5f
Compare
Collaborator
Author
|
PR is ready for review |
elezar
reviewed
Feb 10, 2025
.github/workflows/image.yaml
Outdated
| name: End-to-end Tests | ||
| uses: ./.github/workflows/e2e.yaml | ||
| secrets: inherit | ||
| needs: image |
Member
There was a problem hiding this comment.
Newline:
Suggested change
| needs: image | |
| needs: image | |
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
ArangoGutierrez
force-pushed
the
e2e_tests01
branch
from
a251a5f to
4ded119
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.