Allow nvidia-ctk config --set to accept comma-separated lists #969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR updates the nvidia-ctk configuration command to allow list options to be specified as comma-separated values. It refactors the list-splitting logic in the config module and disables the automatic slice flag separator in the CLI application.
- Refactored list splitting in config.go to check both the provided separator and comma.
- Disabled the slice flag separator in main.go to ensure comma-separated list support.
Reviewed Changes
| File | Description |
|---|---|
| cmd/nvidia-ctk/config/config.go | Updated list splitting logic to support comma-separated values. |
| cmd/nvidia-ctk/main.go | Disabled the slice flag separator in the CLI to complement the new behavior. |
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
ArangoGutierrez
approved these changes
Mar 7, 2025
The urfave update to v2.27.6 fixes the behaviour when disabling a separator for repeated StringSliceFlags. This change updates the nvidia-ctk config command to allow list options to be specified as comma-separated values. Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
allow-comma-separated-config-values
branch
from
ef0f97b to
d32449b
Compare
ArangoGutierrez
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The urfave update to v2.27.6 fixes the behaviour when disabling a separator for repeated StringSliceFlags. This change updates the nvidia-ctk config command to allow list options to be specified as comma-separated values.
For example: