Skip to content

fix(chart): Use image tags instead of digest for multi-registry support #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2025
Merged

fix(chart): Use image tags instead of digest for multi-registry support #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion chart/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ kind: Deployment
metadata:
name: {{ include "chart.fullname" . }}-controller-manager
namespace: "{{ .Release.Namespace }}"
annotations:
checkov.io/skip1: CKV_K8S_43=Image digest not required - we use tags
labels:
app: {{ include "chart.fullname" . }}-controller-manager
app.kubernetes.io/component: manager
Expand Down Expand Up @@ -93,7 +95,7 @@ spec:
- name: KUBERNETES_CLUSTER_DOMAIN
value: {{ quote .Values.kubernetesClusterDomain }}
image: {{ .Values.controllerManager.manager.image.repository }}{{- if .Values.controllerManager.manager.image.digest }}{{- if .Values.controllerManager.manager.image.tag }}:{{ .Values.controllerManager.manager.image.tag }}@{{ .Values.controllerManager.manager.image.digest }}{{- else }}@{{ .Values.controllerManager.manager.image.digest }}{{- end }}{{- else }}:{{ .Values.controllerManager.manager.image.tag | default .Chart.AppVersion }}{{- end }}
imagePullPolicy: IfNotPresent
imagePullPolicy: Always
livenessProbe:
httpGet:
path: /healthz
Expand Down
2 changes: 1 addition & 1 deletion chart/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ controllerManager:
image:
repository: nvcr.io/nvidia/skyhook/operator
tag: "" ## if both tag and digest are omitted, defaults to the chart appVersion
digest: "sha256:b3acae2320d9d768fff455f5986fea9084b099291ecdd258d1580180dabc4efe" # manifest list digest (multi-arch)
digest: "" # manifest list digest (multi-arch)
## agentImage: is the image used for the agent container. This image is the default for this install, but can be overridden in the CR at package level.
agent:
repository: nvcr.io/nvidia/skyhook/agent
Expand Down