Skip to content

Conversation

@edusperoni
Copy link
Contributor

PR Checklist

What is the current behavior?

webpack 5 includes nativescript-hot-loader and the hmr runtime regardless if it's being used or not (which have a nasty side effect of removing sourcemaps for code coverage)

What is the new behavior?

Those are only added when env.hmr is true

@cla-bot cla-bot bot added the cla: yes label Nov 28, 2021
@rigor789 rigor789 merged commit 05082b1 into master Nov 29, 2021
@rigor789 rigor789 deleted the fix/webpack5-hmr-flag branch November 29, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants