Creating RC

.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,29 @@
+---
+name: Bug report
+about: 'We really appreciate your effort to provide feedback. Before opening a new
+  issue, please make sure that this case is not already reported in GitHub as an
+  issue or in StackOverflow as a question.'
+
+---
+
+**Environment**
+Provide version numbers for the following components (information can be retrieved by running `tns info` in your project folder or by inspecting the `package.json` of the project):
+ - CLI: 
+ - Cross-platform modules:
+ - Android Runtime:
+ - iOS Runtime (if applicable):
+ - Plugin(s):
+
+**Describe the bug**
+<!-- A clear and concise description of what the bug is. Please, explain whether it's a build time error or a runtime error. More detailed logs can be easily obtained by following the instructions in this guide: https://docs.nativescript.org/get-support#how-to-obtain-diagnostic-reports. -->
+
+**To Reproduce**
+<!-- Add commands used or steps taken to reproduce the behaviour. -->
+
+**Expected behavior**
+
+**Sample project**
+<!-- If possible, provide a link from the [Playground](https://play.nativescript.org) with reproduction of the problem. If not, consider attaching a sample project or link to a repository with such project. -->
+
+**Additional context**
+<!-- Add any other context about the problem here. -->

.github/ISSUE_TEMPLATE/feature_request.md

@@ -0,0 +1,17 @@
+---
+name: Feature request
+about: Suggest an idea for this project
+
+---
+
+**Is your feature request related to a problem? Please describe.**
+<!-- A clear and concise description of what the problem is. Explain what is stopping you from finishing the job. -->
+
+**Describe the solution you'd like**
+<!-- A clear and concise description of what you want to happen. -->
+
+**Describe alternatives you've considered**
+<!-- A clear and concise description of any alternative solutions or features you've considered. -->
+
+**Additional context**
+<!-- Add any other context or screenshots about the feature request here. -->

CHANGELOG.md

@@ -1,3 +1,18 @@
+5.0.0
+==
+
+## What's New
+- [Upgrade v8 to 6.9.427.23(#1168)](https://github.com/NativeScript/android-runtime/issues/1168)
+- [Added support for before-plugins.gradle file applied before plugin(#1183)](https://github.com/NativeScript/android-runtime/pull/1185)
+- [Make JSParser in SBG fail the build when failing(#1152)](https://github.com/NativeScript/android-runtime/issues/1152)
+- [Generate interface names list in SBG in parallel(#1132)](https://github.com/NativeScript/android-runtime/issues/1132)
+- [Upgrade android gradle plugin to 3.2.0(#1147)](https://github.com/NativeScript/android-runtime/issues/1147)
+
+## Bug Fixes
+
+ - [Static Binding Generator fails if class has static properties that are used within the class(#1160)](https://github.com/NativeScript/android-runtime/issues/1160)
+ - [Fixing NoClassDefFoundError when using older API(#1164)](https://github.com/NativeScript/android-runtime/pull/1164)
+
 4.2.0
 ==
 

README.md

@@ -96,4 +96,4 @@ We love PRs! Check out the [contributing guidelines](CONTRIBUTING.md). If you wa
 * [Implementing additional Chrome DevTools protocol Domains](docs/extending-inspector.md)
 
 ## Get Help
-Please, use [github issues](https://github.com/NativeScript/android-runtime/issues) strictly for [reporting bugs](CONTRIBUTING.md#reporting-bugs) or [requesting features](CONTRIBUTING.md#requesting-new-features). For general questions and support, check out the [NativeScript community forum](https://discourse.nativescript.org/) or ask our experts in [NativeScript community Slack channel](http://developer.telerik.com/wp-login.php?action=slack-invitation).
+Please, use [github issues](https://github.com/NativeScript/android-runtime/issues) strictly for [reporting bugs](CONTRIBUTING.md#reporting-bugs) or [requesting features](CONTRIBUTING.md#requesting-new-features). For general questions and support, check out [Stack Overflow](https://stackoverflow.com/questions/tagged/nativescript) or ask our experts in [NativeScript community Slack channel](http://developer.telerik.com/wp-login.php?action=slack-invitation).

build-artifacts/project-template-gradle/settings.json

@@ -1,3 +1,3 @@
 {
-    "v8Version": "6.7.288.46"
+    "v8Version": "6.9.427.23"
 }

gradle/wrapper/gradle-wrapper.properties

@@ -2,4 +2,4 @@ distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-4.4-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-4.10.2-all.zip

package.json

@@ -1,7 +1,7 @@
 {
   "name": "tns-android",
   "description": "NativeScript Runtime for Android",
-  "version": "4.2.0",
+  "version": "5.0.0",
   "repository": {
     "type": "git",
     "url": "https://github.com/NativeScript/android-runtime.git"
@@ -11,6 +11,6 @@
   ],
   "gradle": {
       "version": "4.4",
-      "android": "3.1.3"
+      "android": "3.1.4"
   }
 }

test-app/app/build.gradle

@@ -75,7 +75,7 @@ def nativescriptDependencies = new JsonSlurper().parseText(dependenciesJson.text
 def computeCompileSdkVersion = { -> project.hasProperty("compileSdk") ? compileSdk : 26 }
 def computeTargetSdkVersion = { -> project.hasProperty("targetSdk") ? targetSdk : 26 }
 def computeBuildToolsVersion = { ->
-    project.hasProperty("buildToolsVersion") ? buildToolsVersion : "27.0.3"
+    project.hasProperty("buildToolsVersion") ? buildToolsVersion : "28.0.2"
 }
 
 project.ext.selectedBuildType = project.hasProperty("release") ? "release" : "debug"
@@ -111,7 +111,17 @@ def getAppResourcesPath = { ->
     project.ext.appResourcesPath = absolutePathToAppResources
 
     return absolutePathToAppResources
-};
+}
+
+def applyBeforePluginGradleConfiguration = { ->
+    def appResourcesPath = getAppResourcesPath()
+    def pathToBeforePluginGradle = "$appResourcesPath/Android/before-plugins.gradle"
+    def beforePluginGradle = file(pathToBeforePluginGradle)
+    if (beforePluginGradle.exists()) {
+        println "\t + applying user-defined configuration from ${beforePluginGradle}"
+        apply from: pathToBeforePluginGradle
+    }
+}
 
 def applyAppGradleConfiguration = { ->
     def appResourcesPath = getAppResourcesPath()
@@ -212,8 +222,9 @@ android {
     }
 
     setAppIdentifier()
-    applyAppGradleConfiguration()
+    applyBeforePluginGradleConfiguration()
     applyPluginGradleConfigurations()
+    applyAppGradleConfiguration()
 }
 
 def externalRuntimeExists = !findProject(':runtime').is(null)
@@ -251,6 +262,8 @@ dependencies {
         supportVer = supportVersion
     }
 
+    println "Using support library version $supportVer"
+
     implementation "com.android.support:multidex:1.0.2"
     implementation "com.android.support:support-v4:$supportVer"
     implementation "com.android.support:appcompat-v7:$supportVer"
@@ -477,14 +490,16 @@ task buildMetadata(type: JavaExec) {
     description "builds metadata with provided jar dependencies"
 
     inputs.files("$MDG_JAVA_DEPENDENCIES")
-    inputs.dir("$buildDir/intermediates/classes")
+
+    def classesDir = "$buildDir/intermediates/javac"
+    inputs.dir(classesDir)
 
     outputs.files("$METADATA_OUT_PATH/treeNodeStream.dat", "$METADATA_OUT_PATH/treeStringsStream.dat", "$METADATA_OUT_PATH/treeValueStream.dat")
 
     doFirst {
         // get compiled classes to pass to metadata generator
         // these need to be called after the classes have compiled
-        def classesDir = "$buildDir/intermediates/classes"
+        assert file(classesDir).exists()
 
         def classesSubDirs = new File(classesDir).listFiles()
         def selectedBuildType = project.ext.selectedBuildType

test-app/app/src/debug/java/com/tns/NativeScriptSyncServiceSocketImpl.java

@@ -58,7 +58,6 @@ public void run() {
                 deviceSystemSocket = new LocalServerSocket(this.name);
                 while (running) {
                     LocalSocket systemSocket = deviceSystemSocket.accept();
-                    systemSocket.setSoTimeout(70000);
                     livesyncWorker = new LiveSyncWorker(systemSocket);
                     Thread liveSyncThread = setUpLivesyncThread();
                     liveSyncThread.start();
@@ -116,7 +115,7 @@ private class LiveSyncWorker implements Runnable {
         public static final String FILE_CONTENT = "fileContent";
         public static final String FILE_CONTENT_LENGTH = FILE_CONTENT + "Length";
         public static final int DEFAULT_OPERATION = -1;
-        private static final String PROTOCOL_VERSION = "0.1.0";
+        private static final String PROTOCOL_VERSION = "0.2.0";
         private byte[] handshakeMessage;
         private final DigestInputStream input;
         private Closeable livesyncSocket;

test-app/app/src/main/assets/app/tests/testsWithContext.js

@@ -1,20 +1,20 @@
 exports.run = function(cntxt)
 {
 	describe("Tests with context ", function () {
-		
+
 		var context = cntxt;
 		var myCustomEquality = function(first, second) {
 			return first == second;
 		};
-		
+
 		beforeEach(function() {
 			jasmine.addCustomEqualityTester(myCustomEquality);
 		});
-		
+
 		it("TestConstructorOverrideForBuiltinType", function () {
-			
+
 			__log("TEST: TestConstructorOverrideForBuiltinType");
-			
+
 			var ctorCalled = false;
 			var isConstructor = false;
 
@@ -24,48 +24,48 @@ exports.run = function(cntxt)
 					isConstructor = arguments[arguments.length - 1];
 				}
 			});
-			
+
 			var btn = new MyButton(context);
-			
+
 			expect(ctorCalled).toEqual(true);
 			expect(isConstructor).toEqual(true);
 		});
-		
+
 		it("TestConstructorOverrideForBuiltinTypeWithInitMethod", function () {
-			
+
 			__log("TEST: TestConstructorOverrideForBuiltinTypeWithInitMethod");
-			
+
 			var initInvocationCount = 0;
 
 			var MyDatePicker = android.widget.DatePicker.extend({
 				init: function() {
 					++initInvocationCount;
 				}
 			});
-			
+
 			var datePicker = new MyDatePicker(context);
-			
+
 			__log("datePicker=" + datePicker);
-			
+
 			var count1 = initInvocationCount;
-			
+
 			expect(count1).toBeGreaterThan(0);
-			
+
 			datePicker.init(2014, 3, 25, null);
-			
+
 			var count2 = initInvocationCount;
-			
+
 			expect(count2).toBeGreaterThan(count1);
 		});
-		
+
 		it("TestBuiltinNestedClassCreation", function () {
-			
+
 			__log("TEST: TestBuiltinNestedClassCreation");
-			
+
 			var loader = new android.content.Loader(context);
 
 			var observer = new android.content.Loader.ForceLoadContentObserver(loader);
-			
+
 			expect(observer).not.toEqual(null);
 		});
 
@@ -82,35 +82,47 @@ exports.run = function(cntxt)
 
             expect(exceptionCaught).toBe(true);
         });
-		
+
 		it("TestPublicWindowManagerImplWithoutMetadata", function () {
-			
+
 			__log("TEST: TestPublicWindowManagerImplWithoutMetadata");
-			
+
 			var windowManagerImpl = context.getSystemService(android.content.Context.WINDOW_SERVICE);
-			
+
 			var display = windowManagerImpl.getDefaultDisplay();
-			
+
 			//__log("display.isValid=" + display.isValid());
-			
+
 			var displayInfo = display.toString();
-			
+
 			expect(displayInfo.length).toBeGreaterThan(0);
 		});
-		
+
 		it("TestCanPassCharSequenceArray", function () {
-			
+
 			__log("TEST: TestCanPassCharSequenceArray");
-			
+
 			var alert = new android.app.AlertDialog.Builder(context);
-		    
+
 		    var builder = alert.setItems(["One", "Two" ], new android.content.DialogInterface.OnClickListener({
 		        onClick: function (dialog, which) {
 		            //
 		        }
 		    }));
-		    
+
 			expect(builder).not.toEqual(null);
 		});
+
+		it("TestOldAPIForGettingMethodsListForMethodsWithParametersFromMissingType", function () {
+            __log("TEST: TestOldAPIForGettingMethodsListForMethodsWithParametersFromMissingType");
+
+            var til = new android.support.design.widget.TextInputLayout(context);
+            var editText = new android.widget.EditText(context);
+            var relativeLayout = new android.widget.RelativeLayout(context);
+            var relativeLayoutParams = new android.widget.RelativeLayout.LayoutParams(android.widget.RelativeLayout.LayoutParams.MATCH_PARENT, android.widget.RelativeLayout.LayoutParams.MATCH_PARENT);
+            relativeLayout.setLayoutParams(relativeLayoutParams);
+            editText.setHint("TEST");
+            til.addView(editText);
+        });
 	});
 };

test-app/build-tools/android-metadata-generator/build.gradle

@@ -17,7 +17,7 @@ buildscript {
     }
 
     dependencies {
-        classpath 'com.android.tools.build:gradle:3.1.3'
+        classpath 'com.android.tools.build:gradle:3.1.4'
     }
 }