fix(metadata-generator): Improve detection of static frameworks#1177
Merged
mbektchiev merged 1 commit intomasterfrom Jul 30, 2019
Merged
fix(metadata-generator): Improve detection of static frameworks#1177mbektchiev merged 1 commit intomasterfrom
mbektchiev merged 1 commit intomasterfrom
Conversation
* Modules with .tbd files which weren't detected as system were wrongly being flagged as static, because `isStaticFramework` returned a `no_such_file_or_directory` error. (e.g. `Accelerate`) * Single architecture dynamic libraries were wrongly being flagged as static, because `isStaticFramework` returned an `invalid_argument` error (e.g. `MetalPerformanceShaders`) * Single architecture static libraries were accidentally being flagged as static, because `isStaticFramework` returned an `invalid_argument` error * Remove TODO comment as irrelevant (no crashes in debug mode)
mbektchiev
force-pushed
the
bektchiev/fix-mg-static-frameworks-detection
branch
from
bdf0efd to
9b89830
Compare
vmutafov
approved these changes
Jul 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as static, because
isStaticFrameworkreturned ano_such_file_or_directoryerroras static, because
isStaticFrameworkreturned aninvalid_argumenterroras static, because
isStaticFrameworkreturned aninvalid_argumenterrorisStaticFrameworkPR Checklist
What is the current behavior?
In the binary metadata some modules' flags were incorrectly written.
What is the new behavior?
The detection of whether a module is dynamic framework or not has been improved
Additional context
Issue was discovered while debugging the causes of #1061 (comment)