Fix TypeScript inheritance of Objective-C classes#252
Merged
fealebenpae merged 1 commit intomasterfrom Jul 31, 2015
Merged
Conversation
There are more places the original constructor function resides in various circumstances. We loop over all the frame registers AND the lexical environment of the scope chain to try and replace the constructor function with our own.
|
✅ |
fealebenpae
added a commit
that referenced
this pull request
Jul 31, 2015
…ve-inheritance-fix Fix TypeScript inheritance of Objective-C classes
fealebenpae
added a commit
that referenced
this pull request
Jul 31, 2015
…ve-inheritance-fix Fix TypeScript inheritance of Objective-C classes
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are more places the original constructor function resides in various circumstances. We loop over all the frame registers AND the lexical environment of the scope chain to try and replace the constructor function with our own.
Fixes #249