Skip to content

Swift modules use mangled name which is different than the klassName so get the name from the metadata#274

Merged
fealebenpae merged 2 commits intomasterfrom
KristinaKoeva/SwiftSupport
Aug 24, 2015
Merged

Swift modules use mangled name which is different than the klassName so get the name from the metadata#274
fealebenpae merged 2 commits intomasterfrom
KristinaKoeva/SwiftSupport

Conversation

@KristinaKoeva
Copy link
Copy Markdown
Contributor

No description provided.

@KristinaKoeva KristinaKoeva added this to the 1.3.0 milestone Aug 20, 2015
Comment thread src/NativeScript/TypeFactory.mm Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just wondering if this should be metadata->name() also?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it should be metadata->name().

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will change it 😞

@ns-bot
Copy link
Copy Markdown

ns-bot commented Aug 20, 2015

@KristinaKoeva KristinaKoeva force-pushed the KristinaKoeva/SwiftSupport branch from 4864549 to d047f57 Compare August 20, 2015 08:28
@ns-bot
Copy link
Copy Markdown

ns-bot commented Aug 20, 2015

@jasssonpet
Copy link
Copy Markdown
Contributor

👍

@ns-bot
Copy link
Copy Markdown

ns-bot commented Aug 21, 2015

@fealebenpae fealebenpae force-pushed the KristinaKoeva/SwiftSupport branch from fc88265 to 40a0303 Compare August 24, 2015 10:43
@ns-bot
Copy link
Copy Markdown

ns-bot commented Aug 24, 2015

fealebenpae added a commit that referenced this pull request Aug 24, 2015
Swift modules use mangled name which is different than the klassName so get the name from the metadata
@fealebenpae fealebenpae merged commit 530ab9a into master Aug 24, 2015
@fealebenpae fealebenpae deleted the KristinaKoeva/SwiftSupport branch August 25, 2015 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants