Skip to content

Move project template files in internal folder - close #308#325

Merged
jasssonpet merged 1 commit intomasterfrom
jasssonpet/move-template-files
Sep 23, 2015
Merged

Move project template files in internal folder - close #308#325
jasssonpet merged 1 commit intomasterfrom
jasssonpet/move-template-files

Conversation

@jasssonpet
Copy link
Copy Markdown
Contributor

New package structure:

tns-ios.tgz
├── WebInspectorUI
│   ├── NativeScript Inspector.zip
│   └── Safari
└── framework
    ├── __PROJECT_NAME__
    │   ├── __PROJECT_NAME__-Info.plist
    │   ├── __PROJECT_NAME__-Prefix.pch
    │   ├── build.xcconfig
    │   └── en.lproj
    │       ├── InfoPlist.strings
    │       └── LaunchScreen.xib
    ├── __PROJECT_NAME__.xcodeproj
    │   ├── project.pbxproj
    └── internal
        ├── NativeScript
        │   ├── Frameworks
        │   │   └── NativeScript.framework
        │   │       ├── Headers
        │   │       │   ├── NativeScript.h
        │   │       │   ├── TNSRuntime+Inspector.h
        │   │       │   └── TNSRuntime.h
        │   │       ├── Info.plist
        │   │       ├── NativeScript
        │   │       └── _CodeSignature
        │   │           └── CodeResources
        │   ├── include
        │   │   ├── NativeScript.h
        │   │   ├── TNSRuntime+Inspector.h
        │   │   └── TNSRuntime.h
        │   └── lib
        │       └── libNativeScript.a
        ├── TNSDebugging.h
        ├── main.m
        ├── metadata-generator
        │   ├── bin
        │   │   ├── metadata-generation-build-step
        │   │   └── objc-metadata-generator
        │   └── lib
        │       └── clang
        │           └── 3.6.0
        │               └── include
        ├── nativescript-build.xcconfig
        ├── nativescript-post-build
        ├── nativescript-pre-build
        ├── nativescript-pre-link
        └── strip-dynamic-framework-architectures.sh

Related to NativeScript/nativescript-cli#951.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line with LaunchScreen.xib got removed by Xcode 7 every time. The file is referenced elsewhere in the project.

@jasssonpet jasssonpet force-pushed the jasssonpet/move-template-files branch 2 times, most recently from ab5c15e to 73adffe Compare September 23, 2015 07:32
@ns-bot
Copy link
Copy Markdown

ns-bot commented Sep 23, 2015

Test PASSed.

@ivanbuhov
Copy link
Copy Markdown
Contributor

👍

@fealebenpae
Copy link
Copy Markdown
Contributor

I wholeheartedly approve, although I want to make a small suggestion:

    NativeScript
    ├── Frameworks
    │   └── NativeScript.framework
    │       ├── Headers
    │       │   ├── NativeScript.h
    │       │   ├── TNSRuntime+Inspector.h
    │       │   └── TNSRuntime.h
    │       ├── Info.plist
    │       ├── NativeScript
    │       └── _CodeSignature
    │           └── CodeResources
    ├── include
    │   ├── NativeScript.h
    │   ├── TNSRuntime+Inspector.h
    │   └── TNSRuntime.h
    └── lib
        └── libNativeScript.a

@jasssonpet jasssonpet force-pushed the jasssonpet/move-template-files branch from 73adffe to b629449 Compare September 23, 2015 11:30
@jasssonpet
Copy link
Copy Markdown
Contributor Author

@fealebenpae I've moved the NativeScript.framework folder inside NativeScript/Frameworks.

@fealebenpae
Copy link
Copy Markdown
Contributor

Alright, I suggest we merge this. Could you please open an issue with the CLI so that they know that the platform update procedure for 1.4 needs to be tweaked again, and let the QAs know that the layout of the npm package has changed?

@jasssonpet
Copy link
Copy Markdown
Contributor Author

There is already a PR in the CLI with the updated project structure: NativeScript/nativescript-cli#951

@fealebenpae
Copy link
Copy Markdown
Contributor

Well, good work, you've earned a muffin :Д

jasssonpet added a commit that referenced this pull request Sep 23, 2015
Move project template files in internal folder - close #308
@jasssonpet jasssonpet merged commit 54017bc into master Sep 23, 2015
@jasssonpet jasssonpet deleted the jasssonpet/move-template-files branch September 23, 2015 11:40
@ns-bot
Copy link
Copy Markdown

ns-bot commented Sep 23, 2015

Test PASSed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants