Move project template files in internal folder - close #308#325
Merged
jasssonpet merged 1 commit intomasterfrom Sep 23, 2015
Merged
Move project template files in internal folder - close #308#325jasssonpet merged 1 commit intomasterfrom
jasssonpet merged 1 commit intomasterfrom
Conversation
Contributor
Author
There was a problem hiding this comment.
This line with LaunchScreen.xib got removed by Xcode 7 every time. The file is referenced elsewhere in the project.
ab5c15e to
73adffe
Compare
|
Test PASSed. |
Contributor
|
👍 |
Contributor
|
I wholeheartedly approve, although I want to make a small suggestion: |
73adffe to
b629449
Compare
Contributor
Author
|
@fealebenpae I've moved the |
Contributor
|
Alright, I suggest we merge this. Could you please open an issue with the CLI so that they know that the platform update procedure for 1.4 needs to be tweaked again, and let the QAs know that the layout of the npm package has changed? |
Contributor
Author
|
There is already a PR in the CLI with the updated project structure: NativeScript/nativescript-cli#951 |
Contributor
|
Well, good work, you've earned a muffin :Д |
jasssonpet
added a commit
that referenced
this pull request
Sep 23, 2015
Move project template files in internal folder - close #308
|
Test PASSed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New package structure:
Related to NativeScript/nativescript-cli#951.