Wrap bridged NSError objects in JavaScript Errors#458
Merged
jasssonpet merged 1 commit intomasterfrom Dec 30, 2015
Merged
Conversation
fealebenpae
force-pushed
the
fealebenpae/wrap-nserror-when-throwing
branch
2 times, most recently
from
4b0a023 to
8797f1f
Compare
Introduce the new NSErrorWrapper that will wrap an NSError thrown in JavaScript so that it can retain the message and stack properties expected in all JavaScript errors.
fealebenpae
force-pushed
the
fealebenpae/wrap-nserror-when-throwing
branch
from
8797f1f to
526f920
Compare
|
Test PASSed. |
jasssonpet
added a commit
that referenced
this pull request
Dec 30, 2015
…en-throwing Wrap bridged NSError objects in JavaScript Errors
Contributor
There was a problem hiding this comment.
Should this be declare-d? I'm receiving the following error:
error TS1038: A 'declare' modifier cannot be used in an already ambient context.
Contributor
Author
There was a problem hiding this comment.
Thats's a good point - please feel free to fix it in-line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce the new
NSErrorWrapperthat will wrap anNSErrorthrown in JavaScript so that it can retain themessageandstackproperties expected in all JavaScript errors.