ES6 Modules#468
Conversation
|
I think it's also safe to delete the BlankApp target. |
|
@jasssonpet Er, why? |
|
The whole purpose of the BlankApp was that the |
|
Also, we will have to update the |
|
Well, yes, that's right, but BlankApp is still the target that just evaluates JavaScript without any module system. If that's not an important distinction then I'll remove it. |
|
Ok, let's leave it for now. |
There was a problem hiding this comment.
Maybe this should be guarded too with #ifdef?
There was a problem hiding this comment.
You mean #ifdef __OBJC__? It's always going to be defined, since this is an .mm file, so it's not necessary.
31dec96 to
126f196
Compare
Naive modules [ES6] CommonJS compatibility [ES6] Expose CommonJS SourceProviders to the DebuggerAgent [ES6] Fixes so that the TestRunner can run [ES6] dump module loading state in Debug builds [ES6] sanitize path resolution [ES6] Circular dependencies in the CommonJS shim [ES6][CommonJS] module.id fixes [ES6] Resolve should support package.json [ES6] import .json files as modules [ES6][CommonJS] require should be a function on the global object Fix linking issues [ES6][CommonJS] modules should be visible to debugger [ES6] Some of the unit tests should use ES6 modules Microtask scheduling should signal AND wake up runloops [ES6] Shims should not be visible in the inspector Use same protocol for app files [ES6] shim modules should use SymbolTable storage [ES6] final polish Allow modules to not export anything [ES6] remove logging formatting Update shared tests
b71e09b to
290ac02
Compare
There was a problem hiding this comment.
I wonder if this string should be autoreleased?
There was a problem hiding this comment.
createCFString returns a WTF::RetainPtr<CFStringRef> which releases the string as soon as it exits scope.
As the title suggests, this introduces support for the ECMAScript 6 Modules syntax. In fact, ES6 Modules are now first-class citizens, with CommonJS support implemented as a shim on top.