fix: Don't disconnect inspector when frontend connects

ptomato · ptomato · commit d2d3b659fd5f · 2023-03-19T17:15:39.000-07:00
This seems incorrect: we disconnect the inspector in the callback for
the frontend being connected. It leads to isConnected_ being false when
we actually go to send the console.log messages to the frontend.

However, I'm not 100% sure whether this is the correct fix. Please check
carefully.
diff --git a/NativeScript/inspector/JsV8InspectorClient.mm b/NativeScript/inspector/JsV8InspectorClient.mm
@@ -105,7 +105,6 @@
     }
 
     this->sender_ = sender;
-    this->disconnect();
 }
 
 void JsV8InspectorClient::onFrontendMessageReceived(std::string message) {

Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,6 @@`
`105`	`105`	`}`
`106`	`106`
`107`	`107`	`this->sender_ = sender;`
`108`		`- this->disconnect();`
`109`	`108`	`}`
`110`	`109`
`111`	`110`	`void JsV8InspectorClient::onFrontendMessageReceived(std::string message) {`