Skip to content

feat: add support for reasons on assertion failure #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2022
Merged

feat: add support for reasons on assertion failure #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion NativeScript/runtime/Helpers.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ const std::string GetCurrentScriptUrl(v8::Isolate* isolate);

bool LiveSync(v8::Isolate* isolate);

void Assert(bool condition, v8::Isolate* isolate = nullptr);
void Assert(bool condition, v8::Isolate* isolate = nullptr, std::string const &reason = std::string());

}

Expand Down
5 changes: 4 additions & 1 deletion NativeScript/runtime/Helpers.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -657,7 +657,7 @@
return true;
}

void tns::Assert(bool condition, Isolate* isolate) {
void tns::Assert(bool condition, Isolate* isolate, std::string const &reason) {
if (!RuntimeConfig.IsDebug) {
assert(condition);
return;
Expand All @@ -676,6 +676,9 @@

if (isolate == nullptr) {
Log(@"====== Assertion failed ======");
if(!reason.empty()) {
Log(@"Reason: %s", reason.c_str());
}
Log(@"Native stack trace:");
LogBacktrace();
assert(false);
Expand Down