Skip to content

fix: crash from unsafe substr operations on path strings #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2025
Merged

fix: crash from unsafe substr operations on path strings #314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions NativeScript/runtime/ModuleInternal.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,7 +638,14 @@ throw NativeScriptException(isolate,
stringByDeletingLastPathComponent] UTF8String];

// Shorten the parentDir for GetRequireFunction to avoid V8 parsing issues with long paths
std::string shortParentDir = "/app" + parentDir.substr(RuntimeConfig.ApplicationPath.length());
std::string shortParentDir;
if (parentDir.length() >= RuntimeConfig.ApplicationPath.length() &&
parentDir.compare(0, RuntimeConfig.ApplicationPath.length(), RuntimeConfig.ApplicationPath) == 0) {
shortParentDir = "/app" + parentDir.substr(RuntimeConfig.ApplicationPath.length());
} else {
// Fallback: use the entire path if it doesn't start with ApplicationPath
shortParentDir = parentDir;
}

Local<v8::Function> require = GetRequireFunction(isolate, shortParentDir);
// Use full paths for __filename and __dirname to match module.id
Expand Down Expand Up @@ -1566,7 +1573,14 @@ throw NativeScriptException(
}

std::string ModuleInternal::GetCacheFileName(const std::string& path) {
std::string key = path.substr(RuntimeConfig.ApplicationPath.size() + 1);
std::string key;
if (path.length() > RuntimeConfig.ApplicationPath.size() &&
path.compare(0, RuntimeConfig.ApplicationPath.size(), RuntimeConfig.ApplicationPath) == 0) {
key = path.substr(RuntimeConfig.ApplicationPath.size() + 1);
} else {
// Fallback: use the entire path if it doesn't start with ApplicationPath
key = path;
}
std::replace(key.begin(), key.end(), '/', '-');

NSArray* paths = NSSearchPathForDirectoriesInDomains(NSCachesDirectory, NSUserDomainMask, YES);
Expand Down