Merge pull request #1818 from NativeScript/hdeshev/test-exit-code

Exit with non-zero code on test failures.

Author: hdeshev

lib/services/karma-execution.ts

@@ -8,7 +8,10 @@ process.on("message", (data: any) => {
 	if(data.karmaConfig) {
 		let pathToKarma = path.join(data.karmaConfig.projectDir, 'node_modules/karma'),
 			KarmaServer = require(path.join(pathToKarma, 'lib/server')),
-			karma = new KarmaServer(data.karmaConfig);
+			karma = new KarmaServer(data.karmaConfig, (exitCode: number) => {
+				//Exit with the correct exit code and signal the manager process.
+				process.exit(exitCode);
+			});
 
 		karma.start();
 	}

lib/services/test-execution-service.ts

@@ -97,50 +97,61 @@ class TestExecutionService implements ITestExecutionService {
 	}
 
 	public startKarmaServer(platform: string): IFuture<void> {
-		return (() => {
-			platform = platform.toLowerCase();
-			this.platform = platform;
+		let karmaFuture = new Future<void>();
 
-			if(this.$options.debugBrk && this.$options.watch) {
-				this.$errors.failWithoutHelp("You cannot use --watch and --debug-brk simultaneously. Remove one of the flags and try again.");
-			}
-
-			if (!this.$platformService.preparePlatform(platform).wait()) {
-				this.$errors.failWithoutHelp("Verify that listed files are well-formed and try again the operation.");
-			}
+		platform = platform.toLowerCase();
+		this.platform = platform;
 
-			let projectDir = this.$projectData.projectDir;
-			this.$devicesService.initialize({ platform: platform, deviceId: this.$options.device }).wait();
+		if(this.$options.debugBrk && this.$options.watch) {
+			this.$errors.failWithoutHelp("You cannot use --watch and --debug-brk simultaneously. Remove one of the flags and try again.");
+		}
 
-			let karmaConfig = this.getKarmaConfiguration(platform),
-				karmaRunner = this.$childProcess.fork(path.join(__dirname, "karma-execution.js"));
+		if (!this.$platformService.preparePlatform(platform).wait()) {
+			this.$errors.failWithoutHelp("Verify that listed files are well-formed and try again the operation.");
+		}
 
-			karmaRunner.send({karmaConfig: karmaConfig});
-			karmaRunner.on("message", (karmaData: any) => {
-				fiberBootstrap.run(() => {
-					this.$logger.trace("## Unit-testing: Parent process received message", karmaData);
-					let port: string;
-					if(karmaData.url) {
-						port = karmaData.url.port;
-						let socketIoJsUrl = `http://${karmaData.url.host}/socket.io/socket.io.js`;
-						let socketIoJs = this.$httpClient.httpRequest(socketIoJsUrl).wait().body;
-						this.$fs.writeFile(path.join(projectDir, TestExecutionService.SOCKETIO_JS_FILE_NAME), socketIoJs).wait();
-					}
+		let projectDir = this.$projectData.projectDir;
+		this.$devicesService.initialize({ platform: platform, deviceId: this.$options.device }).wait();
+
+		let karmaConfig = this.getKarmaConfiguration(platform),
+			karmaRunner = this.$childProcess.fork(path.join(__dirname, "karma-execution.js"));
+
+		karmaRunner.send({karmaConfig: karmaConfig});
+		karmaRunner.on("message", (karmaData: any) => {
+			fiberBootstrap.run(() => {
+				this.$logger.trace("## Unit-testing: Parent process received message", karmaData);
+				let port: string;
+				if(karmaData.url) {
+					port = karmaData.url.port;
+					let socketIoJsUrl = `http://${karmaData.url.host}/socket.io/socket.io.js`;
+					let socketIoJs = this.$httpClient.httpRequest(socketIoJsUrl).wait().body;
+					this.$fs.writeFile(path.join(projectDir, TestExecutionService.SOCKETIO_JS_FILE_NAME), socketIoJs).wait();
+				}
 
-					if(karmaData.launcherConfig) {
-						let configOptions: IKarmaConfigOptions = JSON.parse(karmaData.launcherConfig);
-						let configJs = this.generateConfig(port, configOptions);
-						this.$fs.writeFile(path.join(projectDir, TestExecutionService.CONFIG_FILE_NAME), configJs).wait();
-					}
+				if(karmaData.launcherConfig) {
+					let configOptions: IKarmaConfigOptions = JSON.parse(karmaData.launcherConfig);
+					let configJs = this.generateConfig(port, configOptions);
+					this.$fs.writeFile(path.join(projectDir, TestExecutionService.CONFIG_FILE_NAME), configJs).wait();
+				}
 
-					if(this.$options.debugBrk) {
-						this.getDebugService(platform).debug().wait();
-					} else {
-						this.liveSyncProject(platform).wait();
-					}
-				});
+				if(this.$options.debugBrk) {
+					this.getDebugService(platform).debug().wait();
+				} else {
+					this.liveSyncProject(platform).wait();
+				}
 			});
-		}).future<void>()();
+		});
+		karmaRunner.on("exit", (exitCode: number) => {
+			if (exitCode !== 0) {
+				//End our process with a non-zero exit code
+				const testError = <any>new Error("Test run failed.");
+				testError.suppressCommandHelp = true;
+				karmaFuture.throw(testError);
+			} else {
+				karmaFuture.return();
+			}
+		});
+		return karmaFuture;
 	}
 
 	allowedParameters: ICommandParameter[] = [];