Skip to content

Conversation

@rosen-vladimirov
Copy link
Contributor

CLI must install all project dependencies before running any hook as the hooks are commonly created during the installation of packages. In the current codebase we install the depenencies only during run operation, however we actually need this to be executed before each project preparation.
To fix the behavior move the installation of dependencies in the prepareController and remove it from webpack-compiler-service. Also remove hook which is no longer supported - prepareJS.

PR Checklist

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

CLI must install all project dependencies before running any hook as the hooks are commonly created during the installation of packages. In the current codebase we install the depenencies only during `run` operation, however we actually need this to be executed before each project preparation.
To fix the behavior move the installation of dependencies in the prepareController and remove it from webpack-compiler-service. Also remove hook which is no longer supported - prepareJS.
@rosen-vladimirov
Copy link
Contributor Author

test cli-build package_version#rc

@rosen-vladimirov rosen-vladimirov merged commit 78c5550 into release Jul 10, 2019
@rosen-vladimirov rosen-vladimirov deleted the vladimirov/fix-npm-install branch July 10, 2019 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants