Skip to content
This repository was archived by the owner on Aug 7, 2021. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/before-prepareJS.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,10 @@ const { runWebpackCompiler } = require("./compiler");

module.exports = function ($logger, $liveSyncService, $options, hookArgs) {
const env = hookArgs.config.env || {};
env.hmr = !!$options.hmr;
if ($options.hmr) {
env.hmr = true;
}

const platform = hookArgs.config.platform;
const appFilesUpdaterOptions = hookArgs.config.appFilesUpdaterOptions;
const config = {
Expand Down
56 changes: 29 additions & 27 deletions lib/before-watch.js
Original file line number Diff line number Diff line change
@@ -1,33 +1,35 @@
const { getWebpackProcesses, runWebpackCompiler, stopWebpackCompiler } = require("./compiler");

module.exports = function ($logger, $liveSyncService, $options, $devicesService, hookArgs) {
if (hookArgs.config) {
const appFilesUpdaterOptions = hookArgs.config.appFilesUpdaterOptions;
if (appFilesUpdaterOptions.bundle) {
$liveSyncService.on("liveSyncStopped", data => {
const webpackProcesses = getWebpackProcesses();
Object.keys(webpackProcesses).forEach(platform => {
const devices = $devicesService.getDevicesForPlatform(platform);
if (!devices || !devices.length) {
stopWebpackCompiler(platform);
}
});
});
if (hookArgs.config) {
const appFilesUpdaterOptions = hookArgs.config.appFilesUpdaterOptions;
if (appFilesUpdaterOptions.bundle) {
$liveSyncService.on("liveSyncStopped", data => {
const webpackProcesses = getWebpackProcesses();
Object.keys(webpackProcesses).forEach(platform => {
const devices = $devicesService.getDevicesForPlatform(platform);
if (!devices || !devices.length) {
stopWebpackCompiler(platform);
}
});
});

const platforms = hookArgs.config.platforms;
return Promise.all(platforms.map(platform => {
const env = hookArgs.config.env || {};
env.hmr = !!$options.hmr;
const config = {
env,
platform,
bundle: appFilesUpdaterOptions.bundle,
release: appFilesUpdaterOptions.release,
watch: true
};
const platforms = hookArgs.config.platforms;
return Promise.all(platforms.map(platform => {
const env = hookArgs.config.env || {};
if ($options.hmr) {
env.hmr = true;
}
const config = {
env,
platform,
bundle: appFilesUpdaterOptions.bundle,
release: appFilesUpdaterOptions.release,
watch: true
};

return runWebpackCompiler(config, hookArgs.projectData, $logger, $liveSyncService, hookArgs);
}));
}
}
return runWebpackCompiler(config, hookArgs.projectData, $logger, $liveSyncService, hookArgs);
}));
}
}
}
4 changes: 2 additions & 2 deletions lib/compiler.js
Original file line number Diff line number Diff line change
Expand Up @@ -135,12 +135,12 @@ function buildEnvCommandLineParams(config, envData, $logger) {
const args = [];
envFlagNames.map(item => {
let envValue = envData[item];
if(!Array.isArray(envValue)) {
if (!Array.isArray(envValue)) {
envValue = [envValue];
}
envValue.map(value => args.push(`--env.${item}=${value}`))
});

return args;
}

Expand Down