This repository was archived by the owner on Nov 8, 2023. It is now read-only.
Adding updateDistance option for Android #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
etabakov
suggested changes
Jul 23, 2018
Contributor
etabakov
left a comment
etabakov
left a comment
There was a problem hiding this comment.
Thanks for your effort @denisraison! I noticed two minor issues before proceeding with this PR:
- We've adopted the convention to use code blocks even in case of one-line conditional statements
- In the location-monitor.d.ts file the
updateDistanceproperty of theOptionsinterface is stated that the property is ignored for Android, which will no longer be the case after this PR.
| 0 : options.minimumUpdateTime || Math.min(updateTime, fastestTimeUpdate); | ||
| mLocationRequest.setFastestInterval(minUpdateTime); | ||
| if (options.updateDistance) | ||
| mLocationRequest.setSmallestDisplacement(options.updateDistance); |
Contributor
There was a problem hiding this comment.
Our convention is to use code blocks even in case of one-line If statements.
Changed the description for the updateDistance property
Contributor
Author
|
Hey @etabakov, Thank you! 😄 |
etabakov
approved these changes
Jul 24, 2018
Contributor
|
Everything looks great now. Congrats on your first contribution to @NativeScript's codebase! You just earned the "Contribution" badge.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys,
As I commented here #146 I'm adding the usage of the updateDistance option for Android.
Now we should be able to receive locations update only if the user moved more them X meters on Android too.
🥇