fix ios accuracy #200
fix ios accuracy #200
Conversation
Regardless of desired accuracy when starting location update ios sends a first location as quick as possible even if not with requested accuracy. For ios version 9+ requestLocation API is used, for lower versions the first location received is ignored unless desired accuracy is Accuracy.any.
ghost
added
the
|
Hi @akera-io , I see that there is an CI test that is failing in this PR, can you review it and review your PRs code. The first failure is here: https://travis-ci.org/NativeScript/nativescript-geolocation/jobs/495360697#L347 I see that the error is the same for all failed tests ("Failed: Error: iosLocManager.requestLocation is not a function. (In 'iosLocManager.requestLocation()', 'iosLocManager.requestLocation' is undefined)") |
VladimirAmiorkov
left a comment
VladimirAmiorkov
left a comment
There was a problem hiding this comment.
Unit test are failing with "Failed: Error: iosLocManager.requestLocation is not a function. (In 'iosLocManager.requestLocation()', 'iosLocManager.requestLocation' is undefined)"
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. |
Regardless of desired accuracy when starting location update ios sends a first location as quick as possible even if not with requested accuracy. For ios version 9+ requestLocation API is used, for lower versions the first location received is ignored unless desired accuracy is Accuracy.any.
|
Missed the 'mock' location manager used for tests, did added the new method there and tests seems to pass now. |
|
@akera-io Thank you. We will proceed with testing and will publish a new version as soon as possible. |
|
implementation of feature #202 |
3 participants
When requesting a high accuracy for ios we often receive a not so accurate location due to the fact that when starting update location ios will send a first location as quick as possible although not with the desired accuracy so desiredAccuracy was basically ignored on ios. Since from version 9+ the requestLocation API was introduced thought to use that as well, still if timeout option is specified the good old timer must be used.