-
-
Notifications
You must be signed in to change notification settings - Fork 22
feat: update to Angular 8.0 #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `VirtualTree` class is removed in schematics v8.0.
vakrilov
approved these changes
Jun 20, 2019
Contributor
vakrilov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dtopuzov
added a commit
to NativeScript/nativescript-tooling-qa
that referenced
this pull request
Jun 21, 2019
NativeScript/nativescript-schematics#214 require global installation of NG CLI. Since we do not rely heavily on NG CLI I suggest insalling it globally. If we encounter troubles we may try local install and custom NPM prefix.
dtopuzov
added a commit
to NativeScript/nativescript-tooling-qa
that referenced
this pull request
Jun 21, 2019
Known issue caused by NativeScript/nativescript-schematics#214
dtopuzov
added a commit
to NativeScript/nativescript-tooling-qa
that referenced
this pull request
Jun 25, 2019
* fix: install NG CLI globally NativeScript/nativescript-schematics#214 require global installation of NG CLI. Since we do not rely heavily on NG CLI I suggest insalling it globally. If we encounter troubles we may try local install and custom NPM prefix. * fix: console log messages - Update console log messages. - Install @nativescript/schematics globaly * chore: ignore ng serve --prod Known issue caused by NativeScript/nativescript-schematics#214 * chore: fix app size value * chore: remove tests without bundle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
NativeScript Schematics doesn't work with Angular 8.0.
What is the new behavior?
NativeScript Schematics works with Angular 8.0.