fix: debug-brk does not work with webpack #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case you are using `--bundle`/`--hmr` with `--debug-brk`, application should break in `starter.js`. However, an error is shown. There are several problems - first of app the projectName is calculated incorrectly for iOS, so the path to `platforms/ios/<project name>` is incorrect. Also, as we are modifying the `relativePath` string multiple times, it contains the dir from `nsconfig.json` instead of `app`, but in `platforms` dir, where `starter.js` is located, there's only `app` dir (i.e. no `src` there). Refactor the code, so we'll check the location of the file correctly. Add unit tests for iOS as well.
ghost
assigned
Fatme
approved these changes
Mar 26, 2019
DimitarTachev
approved these changes
Mar 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case you are using
--bundle/--hmrwith--debug-brk, application should break instarter.js. However, an error is shown. There are several problems - first of app the projectName is calculated incorrectly for iOS, so the path toplatforms/ios/<project name>is incorrect.Also, as we are modifying the
relativePathstring multiple times, it contains the dir fromnsconfig.jsoninstead ofapp, but inplatformsdir, wherestarter.jsis located, there's onlyappdir (i.e. nosrcthere). Refactor the code, so we'll check the location of the file correctly. Add unit tests for iOS as well.