Skip to content

Remove package fix #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 15, 2021
Merged

Remove package fix #7

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b9f81e8
fix: Demo support check was broken.
CatchABus Sep 10, 2021
e3926b1
fix: Do not look for `package.json` for demo types that are not suppo…
CatchABus Sep 10, 2021
ca6ed37
chore: Added `TODO` message.
CatchABus Sep 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions packages/plugin-tools/src/generators/remove-package/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export default function (tree: Tree, schema: Schema) {
const demoAppRoot = getDemoAppRoot(t);
removeDemoFiles(tree, t, demoAppRoot);
removeFromDemoIndex(tree, t, demoAppRoot);
updateDemoDependencies(tree, demoAppRoot);
updateDemoDependencies(tree, t, demoAppRoot);
}

removeSharedDemoFiles(tree);
Expand Down Expand Up @@ -120,7 +120,7 @@ function removeFromDemoIndex(tree: Tree, type: SupportedDemoType, demoAppRoot: s
resetAngularIndex(tree);
resetAngularRoutes(tree);
return tree;
} else if (['react', 'svelte', 'vue']) {
} else if (['react', 'svelte', 'vue'].includes(type)) {
// TODO: add index page for these flavors
return tree;
}
Expand Down Expand Up @@ -168,7 +168,12 @@ export function resetAngularRoutes(tree: Tree) {
tree.write(angularRouteModulePath, angularRouteModule);
}

export function updateDemoDependencies(tree: Tree, demoAppRoot: string) {
export function updateDemoDependencies(tree: Tree, type: SupportedDemoType, demoAppRoot: string) {
if (['react', 'svelte', 'vue'].includes(type)) {
// TODO: add index page for these flavors
return;
}

const packagePath = `${demoAppRoot}/package.json`;

updateJson(tree, packagePath, (json) => {
Expand Down