chore: cleanup picker filter feature

Author: NathanWalker

apps/demo/src/plugin-demos/picker.ts

@@ -5,36 +5,36 @@ import { PickerField } from '@nativescript/picker';
 export function navigatingTo(args: EventData) {
 	const page = <Page>args.object;
 	page.bindingContext = new DemoModel();
-	page.bindingContext.set('enableFilterText', 'Enable Filter');
 }
 
-export class DemoModel extends DemoSharedPicker {}
+export class DemoModel extends DemoSharedPicker {
+	enableFilter = false;
+	enableFilterText = 'Enable Filter';
+	toggleFilter(args: EventData) {
+		const view: View = args.object as View;
+		console.log('enableFilter', this.enableFilter);
+		this.enableFilter = !this.enableFilter;
+		this.notifyPropertyChange('enableFilter', this.enableFilter);
+		this.notifyPropertyChange('enableFilterText', this.enableFilter ? 'Hide Filter' : 'Enable Filter');
+		const picker: PickerField = view.page.getViewById('picker');
+		picker.showPicker();
+	}
 
-export function showPicker(args: EventData) {
-	const view: View = args.object as View;
-	const picker: PickerField = view.page.getViewById('picker');
-	picker.showPicker();
+	showPicker(args: EventData) {
+		const view: View = args.object as View;
+		const picker: PickerField = view.page.getViewById('picker');
+		picker.showPicker();
 
-	/*
-    setTimeout(() => {
-        closePicker(args)
-    }, 3000)
-    */
-}
-
-let showFilter = false;
-export function toggleFilter(args: EventData) {
-	const view: View = args.object as View;
-	console.error('enableFilter', showFilter);
-	showFilter = !showFilter;
-	view.page.bindingContext.set('enableFilter', showFilter);
-	view.page.bindingContext.set('enableFilterText', showFilter ? 'Hide Filter' : 'Enable Filter');
-	const picker: PickerField = view.page.getViewById('picker');
-	picker.showPicker();
-}
+		/*
+		setTimeout(() => {
+			closePicker(args)
+		}, 3000)
+		*/
+	}
 
-function closePicker(args: EventData) {
-	const view: View = args.object as View;
-	const picker: PickerField = view.page.getViewById('picker');
-	picker.closePicker();
+	closePicker(args: EventData) {
+		const view: View = args.object as View;
+		const picker: PickerField = view.page.getViewById('picker');
+		picker.closePicker();
+	}
 }

apps/demo/src/plugin-demos/picker.xml

@@ -6,9 +6,9 @@
     <StackLayout class="p-20">
         <ScrollView class="h-full">
           <StackLayout>
-            <Button text="{{ enableFilterText }}" tap="toggleFilter" />
+            <Button text="{{ enableFilterText }}" tap="{{toggleFilter}}" />
 
-            <Button text="Show Picker Programatically" tap="showPicker" />
+            <Button text="Show Picker Programatically" tap="{{showPicker}}" />
 
             <picker:PickerField hintText="Search Items..." focusOnShow="true" filterKeyName="name" showFilter="{{ enableFilter }}" pickerTitle="Nativescript Picker" rowHeight="60" id="picker" hint="Click here" textField="name" padding="10" pickerOpened="{{ pickerOpened }}" pickerClosed="{{ pickerClosed }}"
   								items="{{ pickerItems }}" >

package.json

@@ -40,7 +40,6 @@
 		"nativescript-vue": "~2.9.0",
 		"nativescript-vue-template-compiler": "~2.9.0",
 		"ng-packagr": "^15.0.0",
-		"nx": "^15.4.2",
 		"rxjs": "~7.5.0",
 		"shorthash": "0.0.2",
 		"simple-plist": "^1.1.0",
@@ -54,13 +53,6 @@
 			"npx prettier --write"
 		]
 	},
-	"contributors": [
-		{
-			"name": "KefahB",
-			"email": "kefah.bader@gmail.com",
-			"url": "https://github.com/kefahB"
-		}
-	],
 	"dependencies": {
 		"@nativescript/swift-ui": "^1.0.0-beta.0"
 	}

packages/picker/common.ts

@@ -410,7 +410,7 @@ export class PickerField extends TextField implements TemplatedItemsView {
 	}
 
 	public static showFilterProperty = new Property<PickerField, boolean>({
-		name: 'hideFilter',
+		name: 'showFilter',
 		defaultValue: false,
 		valueConverter: booleanConverter,
 		valueChanged: PickerField.showFilterChanged,

packages/picker/package.json

@@ -25,6 +25,13 @@
 		"name": "NativeScript",
 		"email": "oss@nativescript.org"
 	},
+	"contributors": [
+		{
+			"name": "KefahB",
+			"email": "kefah.bader@gmail.com",
+			"url": "https://github.com/kefahB"
+		}
+	],
 	"bugs": {
 		"url": "https://github.com/NativeScript/plugins/issues"
 	},

packages/picker/project.json

@@ -61,12 +61,5 @@
 				"lintFilePatterns": ["packages/picker/**/*.ts"]
 			}
 		}
-	},
-	"contributors": [
-		{
-			"name": "KefahB",
-			"email": "kefah.bader@gmail.com",
-			"url": "https://github.com/kefahB"
-		}
-	]
+	}
 }